Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932383AbcCVBl7 (ORCPT ); Mon, 21 Mar 2016 21:41:59 -0400 Received: from mail.kernel.org ([198.145.29.136]:53938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754062AbcCVBl5 (ORCPT ); Mon, 21 Mar 2016 21:41:57 -0400 MIME-Version: 1.0 In-Reply-To: References: <1458010724-10945-1-git-send-email-acourbot@nvidia.com> <1458010724-10945-4-git-send-email-acourbot@nvidia.com> <20160318204748.GA20243@rob-hp-laptop> From: Rob Herring Date: Mon, 21 Mar 2016 20:41:33 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 3/5] dt-bindings: Add documentation for GM20B GPU To: Alexandre Courbot Cc: Alexandre Courbot , Stephen Warren , Thierry Reding , "devicetree@vger.kernel.org" , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , "linux-tegra@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 733 Lines: 26 On Sun, Mar 20, 2016 at 1:55 AM, Alexandre Courbot wrote: > On Sat, Mar 19, 2016 at 5:47 AM, Rob Herring wrote: >> On Tue, Mar 15, 2016 at 11:58:42AM +0900, Alexandre Courbot wrote: >>> GM20B's definition is mostly similar to GK20A's, but requires an >>> additional clock. [...] >>> gpu@0,57000000 { >>> compatible = "nvidia,gk20a"; >>> @@ -45,3 +49,22 @@ Example: >>> iommus = <&mc TEGRA_SWGROUP_GPU>; >>> status = "disabled"; >>> }; >>> + >>> +Example for GM20B: >>> + >>> + gpu@0,57000000 { >> >> Drop the comma and leading zero. > > Even though this is how it appears in the actual DT? Yes, those will need to get fixed, too. Rob