Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757947AbcCVDMm (ORCPT <rfc822;w@1wt.eu>);
	Mon, 21 Mar 2016 23:12:42 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:45030 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751111AbcCVDMl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 21 Mar 2016 23:12:41 -0400
Subject: Re: [PATCH v3 0/2] irqchip/mbigen: fix the IO remap problem in mbigen
 driver.
To: Thomas Gleixner <tglx@linutronix.de>
References: <1458203641-17172-1-git-send-email-majun258@huawei.com>
 <alpine.DEB.2.11.1603211124450.3978@nanos>
CC: <Catalin.Marinas@arm.com>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <Will.Deacon@arm.com>,
        <mark.rutland@arm.com>, <marc.zyngier@arm.com>, <jason@lakedaemon.net>,
        <lizefan@huawei.com>, <huxinwei@huawei.com>, <dingtianhong@huawei.com>,
        <liguozhu@hisilicon.com>, <guohanjun@huawei.com>,
        <zhaojunhua@hisilicon.com>
From: "majun (F)" <majun258@huawei.com>
Message-ID: <56F0B7C3.8070001@huawei.com>
Date: Tue, 22 Mar 2016 11:10:59 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.11.1603211124450.3978@nanos>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.177.235.245]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020206.56F0B7D3.0057,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: c94a1e1ad5372a638131e30a3b6a8c40
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1018
Lines: 35



在 2016/3/21 18:29, Thomas Gleixner 写道:
> On Thu, 17 Mar 2016, MaJun wrote:
>> This patch set is used to fix the problem of remap a set of registers
>> repeatedly in current mbigen driver.
>>
>>   irqchip/mbigen:Change the mbigen node definition in dt binding file
>>   irqchip/mbigen:Change the mbigen driver based on the new mbigen node definition
> 
> These subject lines are still horrible as they tell nothing about the nature
> of the change. I fixed them up along with the changelogs and applied them to
> irq/urgent. Can you spot the difference?

Yes, after you changing, the subject and change log clearly show why we need to
do this change.
I have learned a lot from you :)

> 
> While at it. The config switch for this driver is horrible. It's just in the
> middle of the device driver configs. Why is this configurable by the user at
> all? It simply should be selected by arm64 or some subarch configuration
> there. Please clean that up.
> 
will do.

Thanks!
MaJun

> Thanks,
> 
> 	tglx
> 
> .
>