Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751279AbcCVEBC (ORCPT ); Tue, 22 Mar 2016 00:01:02 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:15243 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750824AbcCVEBA (ORCPT ); Tue, 22 Mar 2016 00:01:00 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 21 Mar 2016 20:59:24 -0700 Subject: Re: [PATCH v2 3/5] dt-bindings: Add documentation for GM20B GPU To: Rob Herring , Alexandre Courbot References: <1458010724-10945-1-git-send-email-acourbot@nvidia.com> <1458010724-10945-4-git-send-email-acourbot@nvidia.com> <20160318204748.GA20243@rob-hp-laptop> CC: Stephen Warren , Thierry Reding , "devicetree@vger.kernel.org" , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , "linux-tegra@vger.kernel.org" From: Alexandre Courbot Organization: NVIDIA X-Nvconfidentiality: public Message-ID: <56F0C375.1030907@nvidia.com> Date: Tue, 22 Mar 2016 13:00:53 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.19.57.128] X-ClientProxiedBy: HKMAIL104.nvidia.com (10.18.16.13) To HKMAIL103.nvidia.com (10.18.16.12) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1354 Lines: 38 On 03/22/2016 10:41 AM, Rob Herring wrote: > On Sun, Mar 20, 2016 at 1:55 AM, Alexandre Courbot wrote: >> On Sat, Mar 19, 2016 at 5:47 AM, Rob Herring wrote: >>> On Tue, Mar 15, 2016 at 11:58:42AM +0900, Alexandre Courbot wrote: >>>> GM20B's definition is mostly similar to GK20A's, but requires an >>>> additional clock. > > [...] > >>>> gpu@0,57000000 { >>>> compatible = "nvidia,gk20a"; >>>> @@ -45,3 +49,22 @@ Example: >>>> iommus = <&mc TEGRA_SWGROUP_GPU>; >>>> status = "disabled"; >>>> }; >>>> + >>>> +Example for GM20B: >>>> + >>>> + gpu@0,57000000 { >>> >>> Drop the comma and leading zero. >> >> Even though this is how it appears in the actual DT? > > Yes, those will need to get fixed, too. Sorry, I just want to confirm that I understand why this needs to be fixed. The parent node has #address-cells = <2>, and the practice of specifying two cells in the node name is consistent with what I see in http://www.devicetree.org/Device_Tree_Usage. However in the device tree usage example one can interpret the two cells as being two different components of the address, whereas in our case we are using two cells because the address is 64-bit - hence we should specify it in the name as a single entity. Is this correct? Thanks, Alex.