Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755441AbcCVHRn (ORCPT ); Tue, 22 Mar 2016 03:17:43 -0400 Received: from mail-vk0-f65.google.com ([209.85.213.65]:34613 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751676AbcCVHRe (ORCPT ); Tue, 22 Mar 2016 03:17:34 -0400 MIME-Version: 1.0 In-Reply-To: <20160321210506.GD9749@kroah.com> References: <20160314042831.GA5760@SEL-JYOUN-D1> <20160321210506.GD9749@kroah.com> Date: Tue, 22 Mar 2016 16:17:33 +0900 Message-ID: Subject: Re: [PATCH 2/3] staging: dgnc: use pointer type of tty_struct From: DaeSeok Youn To: Greg KH Cc: Lidza Louina , Mark Hounschell , "driverdev-devel@linuxdriverproject.org" , devel , linux-kernel , kernel-janitors Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 899 Lines: 29 2016-03-22 6:05 GMT+09:00 Greg KH : > On Mon, Mar 14, 2016 at 01:28:31PM +0900, Daeseok Youn wrote: >> For using tty_alloc_driver, SerialDriver has to be pointer type. > > Yes, but you aren't calling tty_alloc_driver, so this patch totally > breaks the working code :( yes.. my changelog was NOT good enough to explain. I was tried to make this patch based on "staging-testing branch" of staging git tree. Actually, I sent 3 patches [1/3] staging: dgnc: fix camelcase of SerialDriver and PrintDriver [2/3] staging: dgnc: use pointer type of tty_struct [3/3] staging: dgnc: use tty_alloc_driver instead of kcalloc without 1/3 patch set, it can break the working code.. (you left a comment on 1/3 and also it couldn't be taken.) > > Please be more careful... Yes, I will be.. Sorry. :-( I will resend a series of patches for this thanks. regards, Daeseok. > > greg k-h