Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758125AbcCVIiI (ORCPT ); Tue, 22 Mar 2016 04:38:08 -0400 Received: from www.linutronix.de ([62.245.132.108]:47237 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751943AbcCVIh6 (ORCPT ); Tue, 22 Mar 2016 04:37:58 -0400 Date: Tue, 22 Mar 2016 09:36:26 +0100 (CET) From: Thomas Gleixner To: Andi Kleen cc: Andy Lutomirski , "linux-kernel@vger.kernel.org" , X86 ML , Andi Kleen Subject: Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base In-Reply-To: <20160321221549.GG5083@two.firstfloor.org> Message-ID: References: <1458576969-13309-1-git-send-email-andi@firstfloor.org> <1458576969-13309-3-git-send-email-andi@firstfloor.org> <20160321220528.GE5083@two.firstfloor.org> <20160321221549.GG5083@two.firstfloor.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1007 Lines: 27 On Mon, 21 Mar 2016, Andi Kleen wrote: > On Mon, Mar 21, 2016 at 03:08:46PM -0700, Andy Lutomirski wrote: > > On Mon, Mar 21, 2016 at 3:05 PM, Andi Kleen wrote: > > >> Please add a patch before this one that renames gs to gsbase. This is > > >> unreadable as is. > > > > > > I investigated this now, and it's not straight forward because on 32bit > > > ->gs is actually gsindex, not gsbase. So with a straight rename you > > > would end up with index in base on 32bit, which would be confusing. > > > > > > > I would take this inconsistency as a reason why this needs to be fixed > > before any further changes are made. > > The patchkit doesn't change anything for 32bit, so any inconsistency > in 32bit is completely orthogonal. > > I don't see how adding a bazillion unrelated changes makes this > patchkit any better. The general rule is that we do necessary cleanups before we change or add new functionality. That's nothing which can be negotiated. Period. Thanks, tglx