Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758470AbcCVJVd (ORCPT ); Tue, 22 Mar 2016 05:21:33 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:37220 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757966AbcCVJVN (ORCPT ); Tue, 22 Mar 2016 05:21:13 -0400 Subject: Re: [PATCH v2 02/18] dt-bindings: timer: sp804: add timer-width property To: Robin Murphy , Rob Herring References: <1457005210-18485-1-git-send-email-narmstrong@baylibre.com> <1457519060-6038-1-git-send-email-narmstrong@baylibre.com> <1457519060-6038-3-git-send-email-narmstrong@baylibre.com> <20160317170926.GA28934@rob-hp-laptop> <56EAF212.7020700@arm.com> <56EB03B3.3070106@arm.com> Cc: "devicetree@vger.kernel.org" , Daniel Lezcano , "linux-kernel@vger.kernel.org" , Sudeep Holla , Russell King , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" From: Neil Armstrong Organization: Baylibre Message-ID: <56F10E84.1080607@baylibre.com> Date: Tue, 22 Mar 2016 10:21:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <56EB03B3.3070106@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1377 Lines: 37 On 03/17/2016 08:21 PM, Robin Murphy wrote: > On 17/03/16 19:00, Rob Herring wrote: >> On Thu, Mar 17, 2016 at 1:06 PM, Robin Murphy wrote: >>> Hi Rob, >>> >>> On 17/03/16 17:09, Rob Herring wrote: >>>> That would not be an SP804 nor would the vendor be ARM in that case. So >>>> add a new compatible string for the vendor that decided to hack up ARM's >>>> IP block. >>> >>> >>> By all accounts this is some ancient reference design[1] which later evolved >>> _into_ the SP804, so that vendor would probably still be ARM ;) >> >> Right. >> >>> A separate compatible string would indeed make more sense, though. Both >>> semantically and in terms of letting the driver account for the differences >>> automatically. >>> >>> Robin. >>> >>> [1]:http://infocenter.arm.com/help/topic/com.arm.doc.ddi0170a/I350250.html >> >> Humm, same as integrator timers perhaps? > > Having had a quick look, what the Integrator/AP manual describes certainly smells like the same basic block as the "AMBA Timer" - 16 bit counters and the same control register layout - albeit in a mutant triple-timer version with a bigger offset between each register set. Integrator/CP, on the other hand, looks much more SP804-like. > > Robin. > Hi, I will switch to oxsemi,ox810se-rps-timer since it need a specific register width that will be handled by the driver. Thanks, Neil