Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758502AbcCVJtQ (ORCPT ); Tue, 22 Mar 2016 05:49:16 -0400 Received: from foss.arm.com ([217.140.101.70]:39905 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758430AbcCVJtJ (ORCPT ); Tue, 22 Mar 2016 05:49:09 -0400 Date: Tue, 22 Mar 2016 09:50:22 +0000 From: Juri Lelli To: Mark Brown Cc: Vincent Guittot , Sai Gurrappadi , linux-kernel , "linux-pm@vger.kernel.org" , LAK , "devicetree@vger.kernel.org" , Peter Zijlstra , Rob Herring , Mark Rutland , Russell King - ARM Linux , Sudeep Holla , Lorenzo Pieralisi , Catalin Marinas , Will Deacon , Morten Rasmussen , Dietmar Eggemann , Pawel Moll , Ian Campbell , Kumar Gala , Maxime Ripard , Olof Johansson , Gregory CLEMENT , Paul Walmsley , Linus Walleij , Chen-Yu Tsai , Thomas Petazzoni , pboonstoppel@nvidia.com Subject: Re: [PATCH v4 2/8] Documentation: arm: define DT cpu capacity bindings Message-ID: <20160322095022.GA23909@e106622-lin> References: <1458311054-13524-1-git-send-email-juri.lelli@arm.com> <1458311054-13524-3-git-send-email-juri.lelli@arm.com> <56EC3F9E.4050209@nvidia.com> <20160321105330.GB12319@e106622-lin> <20160321114956.GD12319@e106622-lin> <20160321121210.GQ2566@sirena.org.uk> <20160321172452.GE12319@e106622-lin> <20160321175112.GY2566@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160321175112.GY2566@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1570 Lines: 36 On 21/03/16 17:51, Mark Brown wrote: > On Mon, Mar 21, 2016 at 05:24:52PM +0000, Juri Lelli wrote: > > > I think this should work, but we have to understand how do we obtain the > > max frequency of each cluster while parsing DT. OPP bindings are > > helpful, but AFAIK there are platforms for which firmware is responsible > > for setting up and advertise available OPPs. I'm not sure if this > > happens later on during the boot process. We might still be able to use > > the clock-frequency property in this case, but that might need changing > > again if the top OPP gets removed/changed. > > > OTH, we might simply want to say that capacity values are to be obtained > > once the platform is "stable" (no additional changes to configuration, > > OPPs, etc.). But this is maybe not acceptable? > > How about we just punt and let the cpufreq driver tell us - it can parse > DT, use built in tables or whatever? We could even remember the raw > values and recalculate if it ever decides to change for some reason. > Until cpufreq comes up we'll be stuck at whatever OPP that we're at on > startup which may not match whatever we define the numbers relative to > anyway. > OK, I'll try and see how that can be done. Thanks, - Juri > > Also, I fear that for variants of a particular implementation we will > > still have to redo the profiling anyway (like we alreaady did for Juno > > and Juno-r2 for example). > > This sometimes happens either through binning or through board design > decisions rather than through new silicon so we might be able to reuse.