Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758524AbcCVKYO (ORCPT ); Tue, 22 Mar 2016 06:24:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:41183 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753480AbcCVKYK (ORCPT ); Tue, 22 Mar 2016 06:24:10 -0400 Subject: Re: [RFC PATCH v1 0/4] Add Rockchip RGA support To: Yakir Yang References: <1458552518-25527-1-git-send-email-ykk@rock-chips.com> <1511371.I0NIYzh3kP@diego> <56EFE66A.8020404@rock-chips.com> Cc: =?UTF-8?Q?Heiko_St=c3=bcbner?= , devicetree@vger.kernel.org, Russell King , Joonyoung Shim , Pawel Moll , Ian Campbell , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , Kumar Gala , linux-arm-kernel@lists.infradead.org, Mark Yao From: =?UTF-8?Q?Andreas_F=c3=a4rber?= X-Enigmail-Draft-Status: N1110 Organization: SUSE Linux GmbH Message-ID: <56F11D46.8080208@suse.de> Date: Tue, 22 Mar 2016 11:24:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56EFE66A.8020404@rock-chips.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1874 Lines: 48 Hi Yakir, Am 21.03.2016 um 13:17 schrieb Yakir Yang: > On 03/21/2016 07:29 PM, Heiko St?bner wrote: >> Am Montag, 21. M?rz 2016, 17:28:38 schrieb Yakir Yang: >>> This patch set would add the RGA direct rendering based 2d graphics >>> acceleration module. >> very cool to see that. > ;) >>> This patch set is based on git repository below: >>> git://people.freedesktop.org/~airlied/linux drm-next >>> commit id: 568d7c764ae01f3706085ac8f0d8a8ac7e826bd7 >>> >>> And the RGA driver is based on Exynos G2D driver, it only manages the >>> command lists received from user, so user should make the command list >>> to data and registers needed by operation to use. >>> >>> I have prepared an userspace demo application for testing: >>> https://github.com/yakir-Yang/libdrm-rockchip >>> That is a rockchip libdrm library, and I have write a simple test case >>> "rockchip_rga_test" that would test the below RGA features: >>> - solid >>> - copy >>> - rotation >>> - flip >>> - window clip >>> - dithering >> Did you submit your libdrm changes as well? >> >> Userspace-interfaces need to be stable so the other side must also get >> accepted - even before the kernel change if I remember correctly. > > Got it, and I just saw exynos_fimg2d already landed at mainline libdrm. > But I don't find the way to submit patches to libdrm, would you like > share some helps here ;) If you're using Exynos as an example, please keep in mind that the libdrm license is MIT/X11, not GPL as the kernel. For our Linux distro we had to disable some Exynos parts because they snuck some GPL code in there and redistributing libdrm under GPL would cause a big headache (review of all packages directly or indirectly linking against it). Thanks, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N?rnberg)