Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758614AbcCVKif (ORCPT ); Tue, 22 Mar 2016 06:38:35 -0400 Received: from mail-oi0-f49.google.com ([209.85.218.49]:36651 "EHLO mail-oi0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758344AbcCVKi1 (ORCPT ); Tue, 22 Mar 2016 06:38:27 -0400 MIME-Version: 1.0 In-Reply-To: <1457077474-124064-2-git-send-email-qiujiang@huawei.com> References: <1457077474-124064-1-git-send-email-qiujiang@huawei.com> <1457077474-124064-2-git-send-email-qiujiang@huawei.com> Date: Tue, 22 Mar 2016 11:38:26 +0100 Message-ID: Subject: Re: [PATCH v5 1/3] gpio: designware: convert device node to fwnode From: Linus Walleij To: qiujiang , Mika Westerberg , "Rafael J. Wysocki" , Lee Jones Cc: Alexandre Courbot , Andy Shevchenko , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , ACPI Devel Maling List , Linuxarm , haifeng.wei@huawei.com, charles.chenxin@huawei.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 938 Lines: 27 On Fri, Mar 4, 2016 at 8:44 AM, qiujiang wrote: > This patch converts device node to fwnode in > dwapb_port_property for designware gpio driver, > so as to provide a unified data structure for DT > and ACPI bindings. > > Acked-by: Andy Shevchenko > Signed-off-by: qiujiang I need Mika's and maybe also Rafael's ACKs on this before I merge any of the series. > --- a/drivers/mfd/intel_quark_i2c_gpio.c > +++ b/drivers/mfd/intel_quark_i2c_gpio.c > @@ -227,7 +227,7 @@ static int intel_quark_gpio_setup(struct pci_dev *pdev, struct mfd_cell *cell) > return -ENOMEM; > > /* Set the properties for portA */ > - pdata->properties->node = NULL; > + pdata->properties->fwnode = NULL; And apparently also the MFD maintainer needs to be involved to ACK this, so add Lee Jones on subsequent postings. Yours, Linus Walleij