Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758914AbcCVL0h (ORCPT ); Tue, 22 Mar 2016 07:26:37 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:33177 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758627AbcCVL02 (ORCPT ); Tue, 22 Mar 2016 07:26:28 -0400 MIME-Version: 1.0 In-Reply-To: <1458603130-6158-1-git-send-email-colin.king@canonical.com> References: <1458603130-6158-1-git-send-email-colin.king@canonical.com> From: "Lad, Prabhakar" Date: Tue, 22 Mar 2016 11:25:57 +0000 Message-ID: Subject: Re: [PATCH] [media] media: am437x-vpfe: ensure ret is initialized To: Colin King Cc: Mauro Carvalho Chehab , linux-media , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 523 Lines: 15 Hi Colin, On Mon, Mar 21, 2016 at 11:32 PM, Colin King wrote: > From: Colin Ian King > > ret should be initialized to 0; for example if pfe->fmt.fmt.pix.field > is V4L2_FIELD_NONE then ret will contain garbage from the > uninitialized state causing garbage to be returned if it is non-zero. > Thanks for the patch, patch [1] fixing this issue is already posted in ML. [1] http://www.mail-archive.com/linux-media@vger.kernel.org/msg95562.html Cheers, --Prabhakar Lad