Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932592AbcCVLmb (ORCPT ); Tue, 22 Mar 2016 07:42:31 -0400 Received: from mail-lb0-f176.google.com ([209.85.217.176]:33885 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758683AbcCVLmY (ORCPT ); Tue, 22 Mar 2016 07:42:24 -0400 From: Sumit Saxena References: <1458493412-17103-1-git-send-email-colin.king@canonical.com> In-Reply-To: <1458493412-17103-1-git-send-email-colin.king@canonical.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQC5pLj2GBEJm/w8R+LbLtQ6RITcHqGVFkIw Date: Tue, 22 Mar 2016 17:12:21 +0530 Message-ID: Subject: RE: [PATCH] megaraid_sas: fix missing { }, nullify kbuff_arr[i] only when necessary To: Colin King , Kashyap Desai , Sumit Saxena , James Bottomley , "Martin K . Petersen" , megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1438 Lines: 50 > -----Original Message----- > From: Colin King [mailto:colin.king@canonical.com] > Sent: Sunday, March 20, 2016 10:34 PM > To: Kashyap Desai; Sumit Saxena; James Bottomley; Martin K . Petersen; > megaraidlinux.pdl@avagotech.com; linux-scsi@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Subject: [PATCH] megaraid_sas: fix missing { }, nullify kbuff_arr[i] only when > necessary > > From: Colin Ian King > > Fix missing { } on if statement, this change will nullify kbuff_arr[i] only where > necessary as the code intended. > > detected using static analysis with smatch > > Signed-off-by: Colin Ian King > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c > b/drivers/scsi/megaraid/megaraid_sas_base.c > index 69d375b..e6ebc7a 100644 > --- a/drivers/scsi/megaraid/megaraid_sas_base.c > +++ b/drivers/scsi/megaraid/megaraid_sas_base.c > @@ -6656,12 +6656,13 @@ out: > } > > for (i = 0; i < ioc->sge_count; i++) { > - if (kbuff_arr[i]) > + if (kbuff_arr[i]) { > dma_free_coherent(&instance->pdev->dev, > le32_to_cpu(kern_sge32[i].length), > kbuff_arr[i], > > le32_to_cpu(kern_sge32[i].phys_addr)); > kbuff_arr[i] = NULL; > + } > } > > megasas_return_cmd(instance, cmd); Acked-by: Sumit Saxena > -- > 2.7.3