Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758981AbcCVMCm (ORCPT ); Tue, 22 Mar 2016 08:02:42 -0400 Received: from foss.arm.com ([217.140.101.70]:40802 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753230AbcCVMCe (ORCPT ); Tue, 22 Mar 2016 08:02:34 -0400 Subject: Re: [PATCH v3 6/9] irqchip/gic-v3: Parse and export virtual GIC information To: Graeme Gregory References: <1457436573-6180-1-git-send-email-julien.grall@arm.com> <1457436573-6180-7-git-send-email-julien.grall@arm.com> <20160322112728.GA2486@xora-haswell.xora.org.uk> Cc: wei@redhat.com, al.stone@linaro.org, kvm@vger.kernel.org, marc.zyngier@arm.com, Jason Cooper , linux-kernel@vger.kernel.org, fu.wei@linaro.org, Thomas Gleixner , kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org, linux-arm-kernel@lists.infradead.org From: Julien Grall Message-ID: <56F13455.2000703@arm.com> Date: Tue, 22 Mar 2016 12:02:29 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160322112728.GA2486@xora-haswell.xora.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1105 Lines: 32 Hi Graeme, On 22/03/16 11:27, Graeme Gregory wrote: > On Tue, Mar 08, 2016 at 11:29:30AM +0000, Julien Grall wrote: >> @@ -1020,6 +1060,13 @@ gic_acpi_parse_madt_gicc(struct acpi_subtable_header *header, >> return -ENOMEM; >> >> gic_acpi_register_redist(gicc->gicr_base_address, redist_base); >> + >> + acpi_data.maint_irq = gicc->vgic_interrupt; >> + acpi_data.maint_irq_mode = (gicc->flags & ACPI_MADT_VGIC_IRQ_MODE) ? >> + ACPI_EDGE_SENSITIVE : ACPI_LEVEL_SENSITIVE; >> + acpi_data.vctrl_base = gicc->gich_base_address; >> + acpi_data.vcpu_base = gicc->gicv_base_address; >> + >> return 0; >> } > > Placing this here means that it will not collect the info in the case > where there is a Generic Interrupt Redistributor structure in the MADT. > > I guess collecting this info should not be a side effect of happening to > pass GICC for redistributor base. Which unfortuneately probably means we > do need to parse the GICCs specifically for this information. I noticed it while testing on some platform. It's now fixed and will be in the next version. Regards, -- Julien Grall