Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758511AbcCVMX5 (ORCPT ); Tue, 22 Mar 2016 08:23:57 -0400 Received: from casper.infradead.org ([85.118.1.10]:52342 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756497AbcCVMXu (ORCPT ); Tue, 22 Mar 2016 08:23:50 -0400 Date: Tue, 22 Mar 2016 13:23:45 +0100 From: Peter Zijlstra To: Michal Hocko Cc: Andrew Morton , linux-mm@kvack.org, LKML , Tetsuo Handa , David Rientjes , Ingo Molnar Subject: Re: [PATCH 1/9] sched: add schedule_timeout_idle() Message-ID: <20160322122345.GN6344@twins.programming.kicks-ass.net> References: <1458644426-22973-1-git-send-email-mhocko@kernel.org> <1458644426-22973-2-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458644426-22973-2-git-send-email-mhocko@kernel.org> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 775 Lines: 22 On Tue, Mar 22, 2016 at 12:00:18PM +0100, Michal Hocko wrote: > extern signed long schedule_timeout_interruptible(signed long timeout); > extern signed long schedule_timeout_killable(signed long timeout); > extern signed long schedule_timeout_uninterruptible(signed long timeout); > +extern signed long schedule_timeout_idle(signed long timeout); > +/* > + * Like schedule_timeout_uninterruptible(), except this task will not contribute > + * to load average. > + */ > +signed long __sched schedule_timeout_idle(signed long timeout) > +{ > + __set_current_state(TASK_IDLE); > + return schedule_timeout(timeout); > +} > +EXPORT_SYMBOL(schedule_timeout_idle); Yes we have 3 such other wrappers, but I've gotta ask: why? They seem pretty pointless. Why not kill the lot?