Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759269AbcCVNTJ (ORCPT ); Tue, 22 Mar 2016 09:19:09 -0400 Received: from mail-oi0-f45.google.com ([209.85.218.45]:34122 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758421AbcCVNSy (ORCPT ); Tue, 22 Mar 2016 09:18:54 -0400 MIME-Version: 1.0 In-Reply-To: <8737rrfe1f.wl%kuninori.morimoto.gx@renesas.com> References: <8760wnfe3r.wl%kuninori.morimoto.gx@renesas.com> <8737rrfe1f.wl%kuninori.morimoto.gx@renesas.com> Date: Tue, 22 Mar 2016 14:18:53 +0100 Message-ID: Subject: Re: [PATCH 2/2] pinctrl: sh-pfc: IPSRx and MOD_SELx should be set before GPSRx From: Linus Walleij To: Kuninori Morimoto Cc: Laurent Pinchart , Geert Uytterhoeven , Magnus , Simon , linux-renesas-soc@vger.kernel.org, "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 678 Lines: 20 On Wed, Mar 16, 2016 at 1:48 AM, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > Gen2 / Gen3 datasheet will have below note in next version. > This patch follows this note. > > IPSRx and MOD_SELx registers shall be set before setting GPSRx > registers in case that they need to be configured. > MOD_SELx registers can be set either earlier or later than setting > IPSRx registers. > > Signed-off-by: Kuninori Morimoto I wait for Geert to either queue this for his first v4.7 pull request or tell me to apply it for fixes. Is it a regression? Yours, Linus Walleij