Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759235AbcCVO2I (ORCPT ); Tue, 22 Mar 2016 10:28:08 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:49227 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754003AbcCVO16 (ORCPT ); Tue, 22 Mar 2016 10:27:58 -0400 X-Envelope-From: stefanr@s5r6.in-berlin.de Date: Tue, 22 Mar 2016 15:27:41 +0100 From: Stefan Richter To: Arnd Bergmann Cc: Tina Ruchandani , y2038@lists.linaro.org, linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firewire: nosy: Replace timeval with timespec64 Message-ID: <20160322152741.61eb2615@kant> In-Reply-To: <3575481.G5vcZLmfxK@wuerfel> References: <20160321055911.GA98166@localhost> <3432361.tg4OvfJSmN@wuerfel> <20160321211917.198f4f03@kant> <3575481.G5vcZLmfxK@wuerfel> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 904 Lines: 21 On Mar 21 Arnd Bergmann wrote: >>> On Sunday 20 March 2016 22:59:11 Tina Ruchandani wrote: >>>> 'struct timeval' uses a 32 bit field for its 'seconds' value which >>>> will overflow in year 2038 and beyond. This patch replaces the use >>>> of timeval in nosy.c with timespec64 which doesn't suffer from y2038 >>>> issue. The code is correct as is - since it is only using the >>>> microseconds portion of timeval. However, this patch does the >>>> replacement as part of a larger effort to remove all instances of >>>> 'struct timeval' from the kernel (that would help identify cases >>>> where the code is actually broken). >>>> >>>> Signed-off-by: Tina Ruchandani [...] > Reviewed-by: Arnd Bergmann Committed to linux1394.git. I will try to get this pulled upstream in the next few days. -- Stefan Richter -======----- --== =-==- http://arcgraph.de/sr/