Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759326AbcCVOag (ORCPT ); Tue, 22 Mar 2016 10:30:36 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33757 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759009AbcCVOa0 (ORCPT ); Tue, 22 Mar 2016 10:30:26 -0400 MIME-Version: 1.0 In-Reply-To: References: <8760wnfe3r.wl%kuninori.morimoto.gx@renesas.com> <8737rrfe1f.wl%kuninori.morimoto.gx@renesas.com> Date: Tue, 22 Mar 2016 15:30:24 +0100 X-Google-Sender-Auth: ccU_mfLYxNeKmsJlN4e-vsvKx6M Message-ID: Subject: Re: [PATCH 2/2] pinctrl: sh-pfc: IPSRx and MOD_SELx should be set before GPSRx From: Geert Uytterhoeven To: Linus Walleij Cc: Kuninori Morimoto , Laurent Pinchart , Geert Uytterhoeven , Magnus , Simon , linux-renesas-soc@vger.kernel.org, "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1154 Lines: 33 Hi Linus, On Tue, Mar 22, 2016 at 2:18 PM, Linus Walleij wrote: > On Wed, Mar 16, 2016 at 1:48 AM, Kuninori Morimoto > wrote: > >> From: Kuninori Morimoto >> >> Gen2 / Gen3 datasheet will have below note in next version. >> This patch follows this note. >> >> IPSRx and MOD_SELx registers shall be set before setting GPSRx >> registers in case that they need to be configured. >> MOD_SELx registers can be set either earlier or later than setting >> IPSRx registers. >> >> Signed-off-by: Kuninori Morimoto > > I wait for Geert to either queue this for his first v4.7 pull request > or tell me to apply it for fixes. Is it a regression? I'm not aware of any issues due to this. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds