Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759401AbcCVOkl (ORCPT ); Tue, 22 Mar 2016 10:40:41 -0400 Received: from mail-ob0-f193.google.com ([209.85.214.193]:33887 "EHLO mail-ob0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756376AbcCVOkd (ORCPT ); Tue, 22 Mar 2016 10:40:33 -0400 MIME-Version: 1.0 In-Reply-To: <20160321221549.GG5083@two.firstfloor.org> References: <1458576969-13309-1-git-send-email-andi@firstfloor.org> <1458576969-13309-3-git-send-email-andi@firstfloor.org> <20160321220528.GE5083@two.firstfloor.org> <20160321221549.GG5083@two.firstfloor.org> Date: Tue, 22 Mar 2016 10:40:32 -0400 Message-ID: Subject: Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base From: Brian Gerst To: Andi Kleen Cc: Andy Lutomirski , "linux-kernel@vger.kernel.org" , X86 ML , Andi Kleen Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 989 Lines: 28 On Mon, Mar 21, 2016 at 6:15 PM, Andi Kleen wrote: > On Mon, Mar 21, 2016 at 03:08:46PM -0700, Andy Lutomirski wrote: >> On Mon, Mar 21, 2016 at 3:05 PM, Andi Kleen wrote: >> >> Please add a patch before this one that renames gs to gsbase. This is >> >> unreadable as is. >> > >> > I investigated this now, and it's not straight forward because on 32bit >> > ->gs is actually gsindex, not gsbase. So with a straight rename you >> > would end up with index in base on 32bit, which would be confusing. >> > >> >> I would take this inconsistency as a reason why this needs to be fixed >> before any further changes are made. > > The patchkit doesn't change anything for 32bit, so any inconsistency > in 32bit is completely orthogonal. The inconsistency is with the 64-bit code. fs/gs imply the %fs and %gs registers (the selector index), not the base. The rename should be: fs -> fsbase gs -> gsbase fsindex -> fs gsindex -> gs -- Brian Gerst