Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932469AbcCVOnS (ORCPT ); Tue, 22 Mar 2016 10:43:18 -0400 Received: from mail.kernel.org ([198.145.29.136]:37879 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753480AbcCVOnE (ORCPT ); Tue, 22 Mar 2016 10:43:04 -0400 Date: Tue, 22 Mar 2016 11:42:58 -0300 From: Arnaldo Carvalho de Melo To: David Sharp Cc: Steven Rostedt , Jiri Olsa , Arnaldo Carvalho de Melo , Josh Poimboeuf , Lucas Stach , Jiri Olsa , linux-kernel@vger.kernel.org, kernel@pengutronix.de, patchwork-lst@pengutronix.de, Wang Nan Subject: Re: [PATCH] tools lib api: respect CROSS_COMPILE for the linker Message-ID: <20160322144258.GC25862@kernel.org> References: <1458235670-27341-1-git-send-email-l.stach@pengutronix.de> <20160318162547.GA2701@redhat.com> <20160318163815.qe7f7cwzis4riwnj@treble.redhat.com> <20160318164522.GB2701@redhat.com> <20160318171623.mih7ozxyinn33ads@treble.redhat.com> <20160318173852.GD2701@redhat.com> <20160321080852.GC3788@krava.brq.redhat.com> <20160321204030.GB2468@redhat.com> <20160322071010.GA26154@krava.brq.redhat.com> <20160322085042.634c68c9@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160322085042.634c68c9@gandalf.local.home> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1569 Lines: 38 Em Tue, Mar 22, 2016 at 08:50:42AM -0400, Steven Rostedt escreveu: > On Tue, 22 Mar 2016 08:10:10 +0100 > Jiri Olsa wrote: > > > On Mon, Mar 21, 2016 at 05:40:30PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Mon, Mar 21, 2016 at 09:08:52AM +0100, Jiri Olsa escreveu: > > > > On Fri, Mar 18, 2016 at 02:38:52PM -0300, Arnaldo Carvalho de Melo wrote: > > > > > Em Fri, Mar 18, 2016 at 12:16:23PM -0500, Josh Poimboeuf escreveu: > > > > > > So 'allow-override' would probably be a good option. > > > > > > > > Humm, my preference is to make tools/ look like the kernel, and the > > > > > kernel doesn't use that allow-override thing, right? So perhaps add what > > > > > is missing to make it look exactly like the kernel and then ditch this > > > > > allow-override thing? > > > > > > > Steven explained his reason for allow-override in the comment above it, > > > > please make sure the new solution follows that > > > > > > Sure, and I'm no make guru, but what puzzles me is why isn't this > > > required in: > > > > > > [acme@jouet linux]$ grep -w ^CC Makefile > > > CC = $(CROSS_COMPILE)gcc > > > [acme@jouet linux]$ > > > > Steve has special requirements I guess ;-) CC-ed > > > > I just copied what I had in trace-cmd. David Sharp is the one that > added that code. > > Link: http://lkml.kernel.org/r/1299791491-1805-1-git-send-email-dhsharp@google.com David, so, what was the usecase for that? Something we can try to reproduce so that we can check if the kernel solution covers your specific case? - Arnaldo