Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755989AbcCVPNS (ORCPT ); Tue, 22 Mar 2016 11:13:18 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:40698 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750701AbcCVPNL (ORCPT ); Tue, 22 Mar 2016 11:13:11 -0400 Date: Tue, 22 Mar 2016 11:13:10 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Oliver Neukum cc: "David S. Miller" , Geert Uytterhoeven , Microchip Linux Driver Support , Woojung Huh , "Rafael J. Wysocki" , Guenter Roeck , , , , Subject: Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM In-Reply-To: <1458656903.1990.12.camel@suse.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 729 Lines: 20 On Tue, 22 Mar 2016, Oliver Neukum wrote: > On Tue, 2016-03-22 at 10:21 -0400, Alan Stern wrote: > > I don't see any point in resuming the device just in order to collect > > operating statistics. If it was already suspended then it wasn't > > operating, so there will be no statistics to collect. > > Indeed. In that case the point is moot. But it is correct to ask > the core whether the device is autosuspended at that point rather > than keep a private flag if you can. That's why we have pm_runtime_status_suspended(). > All that is relevant only if the upper layers ask for information > that the driver cannot provide without resuming the device. > Those are fundamentally different issues. Of course. Alan Stern