Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755865AbcCVPUS (ORCPT ); Tue, 22 Mar 2016 11:20:18 -0400 Received: from resqmta-po-09v.sys.comcast.net ([96.114.154.168]:43309 "EHLO resqmta-po-09v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751721AbcCVPUM (ORCPT ); Tue, 22 Mar 2016 11:20:12 -0400 Date: Tue, 22 Mar 2016 10:20:09 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@east.gentwo.org To: "Kirill A. Shutemov" cc: Andrew Morton , Alexander Viro , Linus Torvalds , Matthew Wilcox , Hugh Dickins , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 0/3] fs, mm: get rid of PAGE_CACHE_* and page_cache_{get,release} macros In-Reply-To: <20160322104113.GA143214@black.fi.intel.com> Message-ID: References: <1458561998-126622-1-git-send-email-kirill.shutemov@linux.intel.com> <20160321163404.GA141069@black.fi.intel.com> <20160321170655.GA141158@black.fi.intel.com> <20160322104113.GA143214@black.fi.intel.com> Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 298 Lines: 11 On Tue, 22 Mar 2016, Kirill A. Shutemov wrote: > > Should then not PAGE_CACHE_SIZE take a page parameter and return the > > correct page size? > > Why? What would you achieve by this? > > We already have a way to find out size of page: compoun_order() or > hpage_nr_pages(). Ok that makes sense.