Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751370AbcCVSYw (ORCPT ); Tue, 22 Mar 2016 14:24:52 -0400 Received: from verein.lst.de ([213.95.11.211]:53156 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbcCVSYl (ORCPT ); Tue, 22 Mar 2016 14:24:41 -0400 Date: Tue, 22 Mar 2016 19:24:39 +0100 From: Christoph Hellwig To: Andrew Price Cc: ccaulfie@redhat.com, teigland@redhat.com, cluster-devel@redhat.com, linux-kernel@vger.kernel.org, hch@lst.de Subject: Re: [PATCH] dlm: config: Fix ENOMEM failures in make_cluster() Message-ID: <20160322182437.GB6797@lst.de> References: <1458668194-23627-1-git-send-email-anprice@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458668194-23627-1-git-send-email-anprice@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 574 Lines: 12 On Tue, Mar 22, 2016 at 05:36:34PM +0000, Andrew Price wrote: > Commit 1ae1602de0 "configfs: switch ->default groups to a linked list" > left the NULL gps pointer behind after removing the kcalloc() call which > made it non-NULL. It also left the !gps check in place so make_cluster() > now fails with ENOMEM. Remove the remaining uses of the gps variable to > fix that. > > Reviewed-by: Bob Peterson > Reviewed-by: Andreas Gruenbacher > Signed-off-by: Andrew Price Oops, sorry. Thanks for fixing this up!