Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751645AbcCVSqJ (ORCPT ); Tue, 22 Mar 2016 14:46:09 -0400 Received: from mail.kernel.org ([198.145.29.136]:51746 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751359AbcCVSqF (ORCPT ); Tue, 22 Mar 2016 14:46:05 -0400 MIME-Version: 1.0 In-Reply-To: <1458669509-7178-1-git-send-email-joro@8bytes.org> References: <1458669509-7178-1-git-send-email-joro@8bytes.org> From: Rob Herring Date: Tue, 22 Mar 2016 13:45:41 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/6] of: Implement iterator for phandles To: Joerg Roedel Cc: Grant Likely , Will Deacon , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Linux IOMMU , "linux-kernel@vger.kernel.org" , Joerg Roedel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 744 Lines: 19 On Tue, Mar 22, 2016 at 12:58 PM, Joerg Roedel wrote: > Hi, > > here is an implementation of the iterator over phandles > concept which Rob Herring suggested to me some time ago. My > approach is a little bit different from what the diff showed > back then, but it gets rid of the allocation and 'struct > 'struct of_phandle_args' misuse. > > I also converted the arm-smmu driver to make use of the > iterator. The resulting kernel boots on my AMD Seattle > system and fixes the warning triggered there. The patches > now also pass all dt-unittests in my kvm environment. > > Please review. Patches are based on v4.5. Other than my one comment, this looks good to me. For the series: Acked-by: Rob Herring