Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752030AbcCVS7G (ORCPT ); Tue, 22 Mar 2016 14:59:06 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:48688 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751204AbcCVS7C (ORCPT ); Tue, 22 Mar 2016 14:59:02 -0400 Date: Tue, 22 Mar 2016 11:59:00 -0700 From: Christoph Hellwig To: Jens Axboe Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, martin.petersen@oracle.com Subject: Re: [PATCH 1/6] block: ensure we don't truncate top bits of the request command flags Message-ID: <20160322185900.GB10113@infradead.org> References: <1458669320-6819-1-git-send-email-axboe@fb.com> <1458669320-6819-2-git-send-email-axboe@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458669320-6819-2-git-send-email-axboe@fb.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 406 Lines: 8 On Tue, Mar 22, 2016 at 11:55:15AM -0600, Jens Axboe wrote: > Some of the flags that we want to use from the make_request_fn path > are now larger than 32-bit, so change the functions involved to > accept an u64 instead of an unsigned int. When did we start doing that? We really should merge Mike's split of the operation style flags into the cmd_type before making things even worse in the flags area.