Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751939AbcCVTTy (ORCPT <rfc822;w@1wt.eu>);
	Tue, 22 Mar 2016 15:19:54 -0400
Received: from www.linutronix.de ([62.245.132.108]:50119 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751628AbcCVTTw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 22 Mar 2016 15:19:52 -0400
Date: Tue, 22 Mar 2016 20:17:53 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@suse.de>
cc: Toshi Kani <toshi.kani@hpe.com>, mingo@kernel.org, hpa@zytor.com,
        mcgrof@suse.com, jgross@suse.com, paul.gortmaker@windriver.com,
        konrad.wilk@oracle.com, elliott@hpe.com, x86@kernel.org,
        xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] x86/mm/pat: Change PAT to support non-default
 PAT MSR
In-Reply-To: <20160322165725.GB5656@pd.tnic>
Message-ID: <alpine.DEB.2.11.1603222015510.3978@nanos>
References: <1458175502-31936-1-git-send-email-toshi.kani@hpe.com> <1458175502-31936-2-git-send-email-toshi.kani@hpe.com> <20160322165725.GB5656@pd.tnic>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 386
Lines: 15

On Tue, 22 Mar 2016, Borislav Petkov wrote:
> > +static void pat_keep_handoff_state(void)
> 
> Static function, no need for "pat_" prefix. Also, no need for the
> kernel-doc comment.

I have to disagree. kernel-doc comments are not limited to global
functions.

I realy prefer kernel-doc style for static functions over randomly formatted
ones for consistency reasons.
 
Thanks,

	tglx