Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752097AbcCVTUJ (ORCPT ); Tue, 22 Mar 2016 15:20:09 -0400 Received: from lists.s-osg.org ([54.187.51.154]:55997 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751953AbcCVTUD (ORCPT ); Tue, 22 Mar 2016 15:20:03 -0400 Subject: Re: [PATCH v14 0/17] Add Analogix Core Display Port Driver To: Doug Anderson , Inki Dae , Jingoo Han , David Airlie References: <1455534485-1154-1-git-send-email-ykk@rock-chips.com> <56EBA305.8030202@gmail.com> Cc: Yakir Yang , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Thierry Reding , Krzysztof Kozlowski , Rob Herring , Heiko Stuebner , Mark Yao , "devicetree@vger.kernel.org" , linux-samsung-soc , Russell King , Pawel Moll , Ian Campbell , "open list:ARM/Rockchip SoC..." , emil.l.velikov@gmail.com, "linux-kernel@vger.kernel.org" , Daniel Kurtz , Kishon Vijay Abraham I , Kukjin Kim , Sean Paul , "dri-devel@lists.freedesktop.org" , Kumar Gala , Ajay kumar , Rob Herring , Andy Yan , Gustavo Padovan , Caesar Wang , "linux-arm-kernel@lists.infradead.org" From: Javier Martinez Canillas Message-ID: <56F19AC9.5060507@osg.samsung.com> Date: Tue, 22 Mar 2016 16:19:37 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2608 Lines: 69 Hello, On 03/18/2016 07:53 PM, Doug Anderson wrote: > Hi, > > On Thu, Mar 17, 2016 at 11:41 PM, Caesar Wang wrote: >> Hi all, >> >> I pick this series up and test on C101PA chromebook, after Heiko update the >> 3 patches. >> >> [v14.1,09/17] drm: rockchip: dp: add rockchip platform dp driver >> [v14.1,04/17] drm: bridge: analogix/dp: fix some obvious code style >> [v14.1,01/17] drm: bridge: analogix/dp: split exynos dp driver to bridge >> directory >> >> C101PA chromebook: >> http://www.amazon.co.uk/10-1-Inch-Chromebook-Rockchip-Integrated-Graphics/dp/B0107N7WT6/ref=lp_758129031_1_4?s=computers&ie=UTF8&qid=1458282912&sr=1-4 >> >> So, verified for the rockchip eDp contrller on my github. >> https://github.com/Caesar-github/rockchip/tree/veyron/next-stable-chromeos > > I did similar to Caesar but I tested on veyron-jerry instead of > veyron-mickey. Like Caesar, I picked these together Heiko's v14.1 > patches to resolve merge conflicts. I also picked into a slightly > different tree (mine was a 4.4-based tree with backports, including > Heiko's latest eDP device tree patches). > I also tested this series on an Exynos5800 Peach Pi Chromebook, using Heiko's branch [0] that is based on today's mainline (968f3e374fa). I've seen no regressions with these patches, DP is working fine and also comes up after a S2R and DPMS on/off using the exynos-drm sysfs. NOTE: I had to cherry-pick a SPI core fix [1] in order to make the Pi to boot. Not related to this series of course but I just mention it in case someone else wants to do the same test on this machine. > Tough I haven't reviewed the code and am not a graphics expert, I'd > very much love to see this landed, presumably right after the merge > window closes. Yakir's first patch > is nearly 1 year old and > it really seems like if there were any major objections left they'd > have been stated by now. v14 appears to be about 1 month old with no > major comments. > Same here, this is the second time I tested this series (first time was v6 on October 25 [2]) and I think that has been out there for too long. > Tested-by: Douglas Anderson > Tested-by: Javier Martinez Canillas > > -Doug > [0]: git://github.com/mmind/linux-rockchip.git tmp/analogix-dp-clean [1]: http://comments.gmane.org/gmane.linux.kernel.spi.devel/23563 [2]: http://lists.infradead.org/pipermail/linux-rockchip/2015-October/004884.html Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America