Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752206AbcCVTrJ (ORCPT ); Tue, 22 Mar 2016 15:47:09 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:36430 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750728AbcCVTrF (ORCPT ); Tue, 22 Mar 2016 15:47:05 -0400 From: Rasmus Villemoes To: Byungho An Cc: Girish K S , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] net: sxgbe: fix error paths in sxgbe_platform_probe() Organization: D03 References: <1455048677-19882-1-git-send-email-linux@rasmusvillemoes.dk> <1455048677-19882-5-git-send-email-linux@rasmusvillemoes.dk> <8737s0d7iz.fsf@rasmusvillemoes.dk> X-Hashcash: 1:20:160322:bh74.an@samsung.com::J15hy2sZ8n3nflFD:0000000000000000000000000000000000000000000j0i X-Hashcash: 1:20:160322:netdev@vger.kernel.org::BytiHiJK4uwfk63R:0000000000000000000000000000000000000001Afd X-Hashcash: 1:20:160322:ks.giri@samsung.com::2HW4SAx1KDgwnYpE:0000000000000000000000000000000000000000004Yeu X-Hashcash: 1:20:160322:linux-kernel@vger.kernel.org::IaJKFhFqC6WKbR3Y:0000000000000000000000000000000008L1r Date: Tue, 22 Mar 2016 20:47:02 +0100 In-Reply-To: <8737s0d7iz.fsf@rasmusvillemoes.dk> (Rasmus Villemoes's message of "Tue, 08 Mar 2016 21:44:20 +0100") Message-ID: <877fgue1mx.fsf@rasmusvillemoes.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1352 Lines: 37 ping^2 On Tue, Mar 08 2016, Rasmus Villemoes wrote: > ping > > On Tue, Feb 09 2016, Rasmus Villemoes wrote: > >> We need to use post-decrement to ensure that irq_dispose_mapping is >> also called on priv->rxq[0]->irq_no; moreover, if one of the above for >> loops failed already at i==0 (so we reach one of these labels with >> that value of i), we'll enter an essentially infinite loop of >> out-of-bounds accesses. >> >> Signed-off-by: Rasmus Villemoes >> --- >> drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c >> index b02eed12bfc5..73427e29df2a 100644 >> --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c >> +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c >> @@ -155,11 +155,11 @@ static int sxgbe_platform_probe(struct platform_device *pdev) >> return 0; >> >> err_rx_irq_unmap: >> - while (--i) >> + while (i--) >> irq_dispose_mapping(priv->rxq[i]->irq_no); >> i = SXGBE_TX_QUEUES; >> err_tx_irq_unmap: >> - while (--i) >> + while (i--) >> irq_dispose_mapping(priv->txq[i]->irq_no); >> irq_dispose_mapping(priv->irq); >> err_drv_remove: