Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752890AbcCVWux (ORCPT ); Tue, 22 Mar 2016 18:50:53 -0400 Received: from mail-vk0-f49.google.com ([209.85.213.49]:32921 "EHLO mail-vk0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752670AbcCVWuv (ORCPT ); Tue, 22 Mar 2016 18:50:51 -0400 MIME-Version: 1.0 In-Reply-To: <1458686031-31031-3-git-send-email-moritz.fischer@ettus.com> References: <1458686031-31031-1-git-send-email-moritz.fischer@ettus.com> <1458686031-31031-3-git-send-email-moritz.fischer@ettus.com> Date: Tue, 22 Mar 2016 15:50:50 -0700 Message-ID: Subject: Re: [RFC 2/2] staging: android: ion: Add of_ion_device_get function From: Moritz Fischer To: Arnd Bergmann Cc: Greg KH , arve@android.com, riandrews@android.com, labbott@redhat.com, sumit.semwal@linaro.org, dan.carpenter@oracle.com, sriram@marirs.net.in, Linux Kernel Mailing List , devel@driverdev.osuosl.org, Moritz Fischer Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1166 Lines: 41 Derp, On Tue, Mar 22, 2016 at 3:33 PM, Moritz Fischer wrote: > Allows to obtain a reference to the global /dev/ion backing > struct ion_device via devicetree. > > Signed-off-by: Moritz Fischer > --- > drivers/staging/android/ion/ion.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c > index e237e9f..cea264e0 100644 > --- a/drivers/staging/android/ion/ion.c > +++ b/drivers/staging/android/ion/ion.c > @@ -64,6 +64,16 @@ struct ion_device { > struct dentry *clients_debug_root; > }; > > +struct ion_device *of_ion_device_get(struct device_node *node) > +{ > + struct miscdevice *mdev = of_misc_get(node); > + > + if (IS_ERR(mdev)) > + return ERR_PTR(PTR_ERR(mdev)); > + > + return container_of(mdev, struct ion_device, dev); > +} > + > /** > * struct ion_client - a process/hw block local address space > * @node: node in the tree of all clients > -- > 2.7.4 > It's missing the header file ... if it's deemed useful at all I'll clean up and resubmit. Moritz