Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752969AbcCVWyq (ORCPT ); Tue, 22 Mar 2016 18:54:46 -0400 Received: from mail-vk0-f50.google.com ([209.85.213.50]:33430 "EHLO mail-vk0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751322AbcCVWym (ORCPT ); Tue, 22 Mar 2016 18:54:42 -0400 MIME-Version: 1.0 In-Reply-To: <1458686031-31031-2-git-send-email-moritz.fischer@ettus.com> References: <1458686031-31031-1-git-send-email-moritz.fischer@ettus.com> <1458686031-31031-2-git-send-email-moritz.fischer@ettus.com> Date: Tue, 22 Mar 2016 15:54:41 -0700 Message-ID: Subject: Re: [RFC 1/2] misc: Add of_get_misc get a reference from devicetree From: Moritz Fischer To: Arnd Bergmann Cc: Greg KH , arve@android.com, riandrews@android.com, labbott@redhat.com, gioh.kim@lge.com, sumit.semwal@linaro.org, dan.carpenter@oracle.com, sriram@marirs.net.in, Linux Kernel Mailing List , devel@driverdev.osuosl.org, Moritz Fischer Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 281 Lines: 19 Meh, On Tue, Mar 22, 2016 at 3:33 PM, Moritz Fischer wrote: > > + > +err_dev: > + put_device(dev); > + return ERR_PTR(ret); > +} > +#else > +struct misc_device *of_misc_get(struct device_node *) Ok, that one is broken .... Sorry, Moritz