Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753464AbcCWBcA (ORCPT ); Tue, 22 Mar 2016 21:32:00 -0400 Received: from down.free-electrons.com ([37.187.137.238]:47660 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752119AbcCWBbw (ORCPT ); Tue, 22 Mar 2016 21:31:52 -0400 Date: Wed, 23 Mar 2016 02:31:39 +0100 From: Alexandre Belloni To: Anthony Olech , stwiss.opensource@diasemi.com Cc: LKML , Alessandro Zummo , Guenter Roeck , Jonathan Cameron , Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-input@vger.kernel.org, Randy Dunlap , rtc-linux@googlegroups.com Subject: Re: [NEW DRIVER V6 0/7] DA9058 PMIC - please comment on this new driver Message-ID: <20160323013139.GD2365@piout.net> References: <201304191703.r3JH3du0017574@latitude> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201304191703.r3JH3du0017574@latitude> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5840 Lines: 133 Hi Anthony, Steve, This driver has been submitted a while ago and reached v6 but still had a few comments. Do you still have some interest in seeing it being accepted? On 19/04/2013 at 17:56:29 +0100, Anthony Olech wrote : > This is submission attempt number 6 to have this driver included in > the linux kernel source tree. This is the driver for the Dialog DA9058. > > The DA9058 is a low power Power Management Integrated Circuit with extra > functionality. It is a Multi Function Device controlled only from an I2C > bus whose components can raise an interrupt request on a single IRQ line. > > The driver for the DA9058 consists of a core (i2c) device driver that > instantiates the individual component device drivers for: > > adc - 5 ADC channels > gpio - 2 available pins > onkey - 1 device > regulator - 4 BUCKS, 19 LDO and 3 fixed > rtc - low power clock > hwmon - 5 monitored voltages/temperatures > > All the above six component device drivers depend on the 'core' > component driver, which is number one in the patch series. > > Each component driver for the Dialog DA9058 will follow as an e-mail > patch relative to > > This driver has been tested on a Samsung SMDK6410 connected to a Dialog > DA9058 Evaluation Board via one GPIO and a 3-wire I2C connection. > > All the components can be builtin to the kernel or compiled as modules. > As far as I can tell, all the latest APIs both for the core driver and > all the component drivers have been adhered to, but if I have missed > something please let me know. > > In a clean check out of next-20130419 in linux-next, each patch has been > applied individually and the final result has been built successfully. > > Many thanks, > Anthony Olech, Dialog Semiconductor Ltd. > > Tony Olech (at Home) (7): > drivers/mfd: DA9058 MFD core driver > drivers/iio/adc: DA9058 ADC driver > drivers/input/misc: DA9058 ONKEY driver > drivers/rtc: DA9058 RTC driver > drivers/gpio: DA9058 GPIO driver > drivers/hwmon: DA9058 HWMON driver > drivers/regulator: DA9058 REGULATOR driver > > Documentation/hwmon/da9058 | 38 ++ > drivers/gpio/Kconfig | 12 + > drivers/gpio/Makefile | 1 + > drivers/gpio/gpio-da9058.c | 376 ++++++++++++++ > drivers/hwmon/Kconfig | 10 + > drivers/hwmon/Makefile | 3 +- > drivers/hwmon/da9058-hwmon.c | 330 ++++++++++++ > drivers/iio/adc/Kconfig | 12 + > drivers/iio/adc/Makefile | 1 + > drivers/iio/adc/da9058-adc.c | 396 ++++++++++++++ > drivers/input/misc/Kconfig | 10 + > drivers/input/misc/Makefile | 1 + > drivers/input/misc/da9058_onkey.c | 173 +++++++ > drivers/mfd/Kconfig | 17 + > drivers/mfd/Makefile | 3 + > drivers/mfd/da9058-core.c | 73 +++ > drivers/mfd/da9058-i2c.c | 96 ++++ > drivers/mfd/da9058-info.c | 939 ++++++++++++++++++++++++++++++++++ > drivers/mfd/da9058-irq.c | 56 ++ > drivers/regulator/Kconfig | 11 + > drivers/regulator/Makefile | 1 + > drivers/regulator/da9058-regulator.c | 199 +++++++ > drivers/rtc/Kconfig | 10 + > drivers/rtc/Makefile | 1 + > drivers/rtc/rtc-da9058.c | 448 ++++++++++++++++ > include/linux/mfd/da9058/adc.h | 18 + > include/linux/mfd/da9058/bat.h | 33 ++ > include/linux/mfd/da9058/codec.h | 22 + > include/linux/mfd/da9058/conf.h | 22 + > include/linux/mfd/da9058/core.h | 66 +++ > include/linux/mfd/da9058/gpio.h | 19 + > include/linux/mfd/da9058/hwmon.h | 32 ++ > include/linux/mfd/da9058/i2c.h | 22 + > include/linux/mfd/da9058/irq.h | 50 ++ > include/linux/mfd/da9058/onkey.h | 17 + > include/linux/mfd/da9058/pdata.h | 30 ++ > include/linux/mfd/da9058/registers.h | 480 +++++++++++++++++ > include/linux/mfd/da9058/regulator.h | 26 + > include/linux/mfd/da9058/rtc.h | 17 + > 39 files changed, 4070 insertions(+), 1 deletion(-) > create mode 100644 Documentation/hwmon/da9058 > create mode 100644 drivers/gpio/gpio-da9058.c > create mode 100644 drivers/hwmon/da9058-hwmon.c > create mode 100644 drivers/iio/adc/da9058-adc.c > create mode 100644 drivers/input/misc/da9058_onkey.c > create mode 100644 drivers/mfd/da9058-core.c > create mode 100644 drivers/mfd/da9058-i2c.c > create mode 100644 drivers/mfd/da9058-info.c > create mode 100644 drivers/mfd/da9058-irq.c > create mode 100644 drivers/regulator/da9058-regulator.c > create mode 100644 drivers/rtc/rtc-da9058.c > create mode 100644 include/linux/mfd/da9058/adc.h > create mode 100644 include/linux/mfd/da9058/bat.h > create mode 100644 include/linux/mfd/da9058/codec.h > create mode 100644 include/linux/mfd/da9058/conf.h > create mode 100644 include/linux/mfd/da9058/core.h > create mode 100644 include/linux/mfd/da9058/gpio.h > create mode 100644 include/linux/mfd/da9058/hwmon.h > create mode 100644 include/linux/mfd/da9058/i2c.h > create mode 100644 include/linux/mfd/da9058/irq.h > create mode 100644 include/linux/mfd/da9058/onkey.h > create mode 100644 include/linux/mfd/da9058/pdata.h > create mode 100644 include/linux/mfd/da9058/registers.h > create mode 100644 include/linux/mfd/da9058/regulator.h > create mode 100644 include/linux/mfd/da9058/rtc.h > > -- > end-of-patch for NEW DRIVER V6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com