Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753848AbcCWCWg (ORCPT <rfc822;w@1wt.eu>);
	Tue, 22 Mar 2016 22:22:36 -0400
Received: from mga01.intel.com ([192.55.52.88]:65223 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753730AbcCWCW3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 22 Mar 2016 22:22:29 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,380,1455004800"; 
   d="scan'208";a="943091636"
Subject: Re: [PATCH] KVM: page_track: fix access to NULL slot
To: Paolo Bonzini <pbonzini@redhat.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
References: <1458664809-4129-1-git-send-email-pbonzini@redhat.com>
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Message-ID: <56F1FD9B.6030705@linux.intel.com>
Date: Wed, 23 Mar 2016 10:21:15 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1458664809-4129-1-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 953
Lines: 21



On 03/23/2016 12:40 AM, Paolo Bonzini wrote:
> This happens when doing the reboot test from virt-tests:
>
> [  131.833653] BUG: unable to handle kernel NULL pointer dereference at           (null)
> [  131.842461] IP: [<ffffffffa0950087>] kvm_page_track_is_active+0x17/0x60 [kvm]
> [  131.850500] PGD 0
> [  131.852763] Oops: 0000 [#1] SMP
> [  132.007188] task: ffff880075fbc500 ti: ffff880850a3c000 task.ti: ffff880850a3c000
> [  132.138891] Call Trace:
> [  132.141639]  [<ffffffffa092bd11>] page_fault_handle_page_track+0x31/0x40 [kvm]
> [  132.149732]  [<ffffffffa093380f>] paging64_page_fault+0xff/0x910 [kvm]
> [  132.172159]  [<ffffffffa092c734>] kvm_mmu_page_fault+0x64/0x110 [kvm]
> [  132.179372]  [<ffffffffa06743c2>] handle_exception+0x1b2/0x430 [kvm_intel]
> [  132.187072]  [<ffffffffa067a301>] vmx_handle_exit+0x1e1/0xc50 [kvm_intel]
> ...

Thank you for fixing it, Paolo!

Reviewed-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>