Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753790AbcCWCeB (ORCPT ); Tue, 22 Mar 2016 22:34:01 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:34513 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753508AbcCWCdy (ORCPT ); Tue, 22 Mar 2016 22:33:54 -0400 Message-ID: <1458700432.10868.32.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: [PATCH] vlan: propagate gso_min_segs From: Eric Dumazet To: Haishuang Yan Cc: Patrick McHardy , "David S. Miller" , Nicolas Dichtel , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 22 Mar 2016 19:33:52 -0700 In-Reply-To: <1458696914-16088-1-git-send-email-yanhaishuang@cmss.chinamobile.com> References: <1458696914-16088-1-git-send-email-yanhaishuang@cmss.chinamobile.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 455 Lines: 15 On Wed, 2016-03-23 at 09:35 +0800, Haishuang Yan wrote: > vlan drivers lack proper propagation of gso_min_segs from lower device. > > Signed-off-by: Haishuang Yan > --- The plan was to get rid of gso_min_segs, as nothing uses it. Otherwise I would have included this in my recent patches... For such a rare 'issue' , we believe ndo_features_check() is better, because it does not slow down the fast path. Thanks.