Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753964AbcCWCjo (ORCPT ); Tue, 22 Mar 2016 22:39:44 -0400 Received: from mga09.intel.com ([134.134.136.24]:36193 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753568AbcCWCjd (ORCPT ); Tue, 22 Mar 2016 22:39:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,380,1455004800"; d="scan'208";a="939629751" Date: Wed, 23 Mar 2016 10:38:12 +0800 From: kbuild test robot To: Ming Lin Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Christoph Hellwig Subject: [PATCH] lib: scatterlist: fix ifnullfree.cocci warnings Message-ID: <20160323023812.GA163037@athens> References: <201603231036.A8dUuAli%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458684196-15923-6-git-send-email-mlin@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1246 Lines: 33 lib/sg_pool.c:152:3-18: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. lib/sg_pool.c:154:3-21: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Ming Lin Signed-off-by: Fengguang Wu --- sg_pool.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- a/lib/sg_pool.c +++ b/lib/sg_pool.c @@ -148,10 +148,8 @@ static __init int sg_pool_init(void) cleanup_sdb: for (i = 0; i < SG_MEMPOOL_NR; i++) { struct sg_pool *sgp = sg_pools + i; - if (sgp->pool) - mempool_destroy(sgp->pool); - if (sgp->slab) - kmem_cache_destroy(sgp->slab); + mempool_destroy(sgp->pool); + kmem_cache_destroy(sgp->slab); } return -ENOMEM;