Message-ID: <1458703028.22080.7.camel@perches.com>
Subject: Re: [PATCH 4/5] mm/lru: is_file/active_lru can be boolean
From: Joe Perches <joe@perches.com>
To: Yaowei Bai <baiyaowei@cmss.chinamobile.com>, akpm@linux-foundation.org
Cc: n-horiguchi@ah.jp.nec.com, kirill.shutemov@linux.intel.com,
        rientjes@google.com, iamjoonsoo.kim@lge.com, hannes@cmpxchg.org,
        vdavydov@virtuozzo.com, kuleshovmail@gmail.com, vbabka@suse.cz,
        mgorman@techsingularity.net, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Date: Tue, 22 Mar 2016 20:17:08 -0700
In-Reply-To: <1458699969-3432-5-git-send-email-baiyaowei@cmss.chinamobile.com>
References: <1458699969-3432-1-git-send-email-baiyaowei@cmss.chinamobile.com>
	 <1458699969-3432-5-git-send-email-baiyaowei@cmss.chinamobile.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 783
Lines: 17

On Wed, 2016-03-23 at 10:26 +0800, Yaowei Bai wrote:
> This patch makes is_file/active_lru return bool to improve
> readability due to these particular functions only using either
> one or zero as their return value.
> 
> No functional change.

These assignments to int should likely be modified too

$ git grep -w -n is_file_lru
include/linux/mmzone.h:191:static inline int is_file_lru(enum lru_list lru)
mm/vmscan.c:1404:???????????????????????????????????nr_taken, mode, is_file_lru(lru));
mm/vmscan.c:1525:???????????????????????int file = is_file_lru(lru);
mm/vmscan.c:1581:???????int file = is_file_lru(lru);
mm/vmscan.c:1783:???????int file = is_file_lru(lru);
mm/vmscan.c:1934:???????if (is_file_lru(lru))
mm/vmscan.c:2129:???????????????????????int file = is_file_lru(lru);