Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754129AbcCWFj4 (ORCPT ); Wed, 23 Mar 2016 01:39:56 -0400 Received: from mga02.intel.com ([134.134.136.20]:39961 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753654AbcCWFjk convert rfc822-to-8bit (ORCPT ); Wed, 23 Mar 2016 01:39:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,381,1455004800"; d="scan'208";a="939703977" From: "Dilger, Andreas" To: James Simmons CC: "devel@driverdev.osuosl.org" , "Drokin, Oleg" , Linux Kernel Mailing List , Lustre Development List , Greg Kroah-Hartman Subject: Re: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type." Thread-Topic: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type." Thread-Index: AQHRhKY5PW+G72WTyUyyOK11dCobdZ9mlDsA Date: Wed, 23 Mar 2016 05:39:36 +0000 Message-ID: References: <1458685264-22755-1-git-send-email-jsimmons@infradead.org> <20160323014916.GF3190@kroah.com> In-Reply-To: <20160323014916.GF3190@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.84.253] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2058 Lines: 65 On 2016/03/22, 19:49, "lustre-devel on behalf of Greg Kroah-Hartman" wrote: >On Tue, Mar 22, 2016 at 06:21:04PM -0400, James Simmons wrote: >> Latest testing fails when using ko2iblnd. It was tracked down >> to commit 4671a026616df26000f7d8ad2f2ea4b6de79263c. >> >> This reverts commit 4671a026616df26000f7d8ad2f2ea4b6de79263c. >> --- >> .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c >>b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c >> index 89f9390..0d32e65 100644 >> --- a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c >> +++ b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c >> @@ -1968,7 +1968,7 @@ static int kiblnd_net_init_pools(kib_net_t *net, >>__u32 *cpts, int ncpts) >> */ >> >> net->ibn_fmr_ps = cfs_percpt_alloc(lnet_cpt_table(), >> - sizeof(*net->ibn_fmr_ps)); >> + sizeof(kib_fmr_poolset_t)); > >Ok, why is this revert needed? Please give me a big huge comment about >why this is not the same size of the variable being assigned to it, >otherwise someone else is going to come along and make the exact same >change again. > >> if (!net->ibn_fmr_ps) { >> CERROR("Failed to allocate FMR pool array\n"); >> rc = -ENOMEM; >> @@ -1992,7 +1992,7 @@ static int kiblnd_net_init_pools(kib_net_t *net, >>__u32 *cpts, int ncpts) >> >> create_tx_pool: >> net->ibn_tx_ps = cfs_percpt_alloc(lnet_cpt_table(), >> - sizeof(*net->ibn_tx_ps)); >> + sizeof(kib_tx_poolset_t)); > >Same here, why is this code wrong? Looks like the declarations are: kib_tx_poolset_t **ibn_tx_ps; /* tx pool-set */ kib_fmr_poolset_t **ibn_fmr_ps; /* fmr pool-set */ so the right code should be: sizeof(**net->ibn_tx_ps); and the same for sizeof(**net->ibn_fmr_ps) Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel High Performance Data Division