Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753251AbcCWGIT (ORCPT ); Wed, 23 Mar 2016 02:08:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:55689 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750804AbcCWGIS (ORCPT ); Wed, 23 Mar 2016 02:08:18 -0400 Subject: Re: [PATCH v2 5/6] x86/xen,pat: Remove PAT table init code from Xen To: Borislav Petkov , Toshi Kani References: <1458175619-32206-1-git-send-email-toshi.kani@hpe.com> <1458175619-32206-4-git-send-email-toshi.kani@hpe.com> <20160322170206.GF5656@pd.tnic> Cc: mingo@kernel.org, hpa@zytor.com, tglx@linutronix.de, mcgrof@suse.com, paul.gortmaker@windriver.com, konrad.wilk@oracle.com, elliott@hpe.com, x86@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org From: Juergen Gross Message-ID: <56F232CE.8010706@suse.com> Date: Wed, 23 Mar 2016 07:08:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160322170206.GF5656@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1263 Lines: 36 On 22/03/16 18:02, Borislav Petkov wrote: > On Wed, Mar 16, 2016 at 06:46:58PM -0600, Toshi Kani wrote: >> Xen supports PAT without MTRR for its guests. In order to >> enable WC attribute, it was necessary for xen_start_kernel() >> to call pat_init_cache_modes() to update PAT table before >> starting guest kernel. >> >> Now that the kernel initializes PAT table to the BIOS handoff >> state when MTRR is disabled, this Xen-specific PAT init code >> is no longer necessary. Delete it from xen_start_kernel(). >> >> Also change pat_init_cache_modes() to a static function since >> PAT table should not be tweaked by other modules. >> >> Signed-off-by: Toshi Kani >> Cc: Konrad Rzeszutek Wilk >> Cc: Borislav Petkov >> Cc: Luis R. Rodriguez >> Cc: Juergen Gross >> Cc: Ingo Molnar >> Cc: H. Peter Anvin >> Cc: Thomas Gleixner >> --- >> arch/x86/include/asm/pat.h | 1 - >> arch/x86/mm/pat.c | 2 +- >> arch/x86/xen/enlighten.c | 9 --------- >> 3 files changed, 1 insertion(+), 11 deletions(-) > > Jürgen, ack? Yes, seems to be okay. Acked-by: Juergen Gross Juergen