Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754466AbcCWIdy (ORCPT ); Wed, 23 Mar 2016 04:33:54 -0400 Received: from mga01.intel.com ([192.55.52.88]:21415 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754304AbcCWIds convert rfc822-to-8bit (ORCPT ); Wed, 23 Mar 2016 04:33:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,381,1455004800"; d="scan'208";a="930016311" From: "Grumbach, Emmanuel" To: Eva Rachel Retuya , "outreachy-kernel@googlegroups.com" CC: "Berg, Johannes" , linuxwifi , "kvalo@codeaurora.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tj@kernel.org" Subject: Re: [PATCH v3] iwlwifi: dvm: use alloc_ordered_workqueue() Thread-Topic: [PATCH v3] iwlwifi: dvm: use alloc_ordered_workqueue() Thread-Index: AQHRgZ5ra8lUun/UbU2w/dHC8kMXjQ== Date: Wed, 23 Mar 2016 08:33:41 +0000 Message-ID: <0BA3FCBA62E2DC44AF3030971E174FB32EA8768F@hasmsx107.ger.corp.intel.com> References: <1458364547-11621-1-git-send-email-eraretuya@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.12.124.189] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 674 Lines: 20 On 03/19/2016 07:15 AM, Eva Rachel Retuya wrote: > Use alloc_ordered_workqueue() to allocate the workqueue instead of > create_singlethread_workqueue() since the latter is deprecated and is scheduled > for removal. > > There are work items doing related operations that shouldn't be swapped when > queued in a certain order hence preserve the strict execution ordering of a > single threaded (ST) workqueue by switching to alloc_ordered_workqueue(). > > WQ_MEM_RECLAIM flag is not needed since the worker is not depended > during memory reclaim. > > Signed-off-by: Eva Rachel Retuya > Acked-by: Tejun Heo > --- Applied - thanks.