Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754151AbcCWKed (ORCPT ); Wed, 23 Mar 2016 06:34:33 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:57164 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539AbcCWKeZ (ORCPT ); Wed, 23 Mar 2016 06:34:25 -0400 Date: Wed, 23 Mar 2016 10:34:15 +0000 From: Mark Brown To: Alexander Stein Cc: linux-kernel@vger.kernel.org Message-ID: <20160323103415.GG2566@sirena.org.uk> References: <1981840.HVGTg07J9M@ws-stein> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zN1HJFR/B7wwTray" Content-Disposition: inline In-Reply-To: <1981840.HVGTg07J9M@ws-stein> X-Cookie: Walk softly and carry a megawatt laser. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: regmap: mmio: regression in pre-v4.6-rc1 X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1718 Lines: 44 --zN1HJFR/B7wwTray Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 23, 2016 at 09:48:42AM +0100, Alexander Stein wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > I'm currently trying to get PCIe working on LS1021A (little-endian > ARM). For link-detection I need access to a syscon perpheral (SCFG) > which is attched to CPU as big-endian. Are you *sure* that this is actually big endian? Are you basing this on documentation or on what happened to work for you in the past. > Based on current linus's master (a24e3d414e59ac765, "Merge branch > 'akpm' (patches from Andrew)") I noticed the access is actually done > as little-endian. I could track it down to commit 922a9f936e40001f > ("regmap: mmio: Convert to regmap_bus and fix accessor usage"). > Reverting it, the access is fine now and I get my PCIe link. Have you tried tracing through the code to see what ends up happening to the I/O? It should come out using your architecture's big endian accessors. --zN1HJFR/B7wwTray Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW8nEmAAoJECTWi3JdVIfQzZgIAIAcG+JFBuxBVJ/ZwhmGGjT4 6/HNKz92BU73YAvsfW9wxng2m5o7PXs5GfKrN211LM8L9OAwAmK3+jF+CQMh5+lH Ap64zha6R4gNsiB1mc37xne6DnrFN9O34+xFs7FU551taa8RPt6jQ/TdovAqj+/K 5QhK0XOK9m3XYq3tvOJEefMXAzP5OWr6loPscbn3WkIDK2OmbsiEi5z8uGWeo6A7 1XWVj27+TAp+SIHqFD/IX0sqE5gjBrwEgkzAYRdMOjcnfm3M5wkOlbNfQ49HbwLf R72kg0cV5K8B0+11Fg77VVVq4MNXSEwDCilPYhCkW4aGVGtQkVgh3gFwfijk++M= =s0Zl -----END PGP SIGNATURE----- --zN1HJFR/B7wwTray--