Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755011AbcCWLYc (ORCPT <rfc822;w@1wt.eu>);
	Wed, 23 Mar 2016 07:24:32 -0400
Received: from eusmtp01.atmel.com ([212.144.249.243]:56450 "EHLO
	eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754915AbcCWLYX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 23 Mar 2016 07:24:23 -0400
Subject: Re: [RESEND PATCH] ARM: at91/dt: sama5d2: add SFR node
To: Ludovic Desroches <ludovic.desroches@atmel.com>,
        <alexandre.belloni@free-electrons.com>
References: <1458230640-26049-1-git-send-email-ludovic.desroches@atmel.com>
CC: <plagnioj@jcrosoft.com>, <cyrille.pitchen@atmel.com>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <boris.brezillon@free-electrons.com>
From: Nicolas Ferre <nicolas.ferre@atmel.com>
Organization: atmel
Message-ID: <56F27CEA.7000509@atmel.com>
Date: Wed, 23 Mar 2016 12:24:26 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <1458230640-26049-1-git-send-email-ludovic.desroches@atmel.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.161.30.18]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2639
Lines: 80

Le 17/03/2016 17:04, Ludovic Desroches a ?crit :
> From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> 
> This SFR node is looked up by the I2S controller driver to tune the
> SFR_I2SCLKSEL register.
> 
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

I'll queue it in our upcoming at91-4.7-dt branch. Thanks!

Bye,

> ---
>  Documentation/devicetree/bindings/arm/atmel-at91.txt |  2 +-
>  arch/arm/boot/dts/sama5d2.dtsi                       |  5 +++++
>  include/soc/at91/atmel-sfr.h                         | 18 ++++++++++++++++++
>  3 files changed, 24 insertions(+), 1 deletion(-)
>  create mode 100644 include/soc/at91/atmel-sfr.h
> 
> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.txt b/Documentation/devicetree/bindings/arm/atmel-at91.txt
> index 7fd64ec..550fd66 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-at91.txt
> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.txt
> @@ -155,7 +155,7 @@ elsewhere.
>  
>  required properties:
>  - compatible: Should be "atmel,<chip>-sfr", "syscon".
> -  <chip> can be "sama5d3" or "sama5d4".
> +  <chip> can be "sama5d3", "sama5d4" or "sama5d2".
>  - reg: Should contain registers location and length
>  
>  	sfr@f0038000 {
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 78996bd..36bb29c 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -973,6 +973,11 @@
>  				status = "disabled";
>  			};
>  
> +			sfr: sfr@f8030000 {
> +				compatible = "atmel,sama5d2-sfr", "syscon";
> +				reg = <0xf8030000 0x98>;
> +			};
> +
>  			flx0: flexcom@f8034000 {
>  				compatible = "atmel,sama5d2-flexcom";
>  				reg = <0xf8034000 0x200>;
> diff --git a/include/soc/at91/atmel-sfr.h b/include/soc/at91/atmel-sfr.h
> new file mode 100644
> index 0000000..2f9bb98
> --- /dev/null
> +++ b/include/soc/at91/atmel-sfr.h
> @@ -0,0 +1,18 @@
> +/*
> + * Atmel SFR (Special Function Registers) register offsets and bit definitions.
> + *
> + * Copyright (C) 2016 Atmel
> + *
> + * Author: Ludovic Desroches <ludovic.desroches@atmel.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#ifndef _LINUX_MFD_SYSCON_ATMEL_SFR_H
> +#define _LINUX_MFD_SYSCON_ATMEL_SFR_H
> +
> +#define AT91_SFR_I2SCLKSEL	0x90	/* I2SC Register */
> +
> +#endif /* _LINUX_MFD_SYSCON_ATMEL_SFR_H */
> 


-- 
Nicolas Ferre