Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754928AbcCWL3X (ORCPT ); Wed, 23 Mar 2016 07:29:23 -0400 Received: from www.linutronix.de ([62.245.132.108]:52540 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751741AbcCWL3P (ORCPT ); Wed, 23 Mar 2016 07:29:15 -0400 Date: Wed, 23 Mar 2016 12:27:44 +0100 (CET) From: Thomas Gleixner To: Alex Thorlton cc: linux-kernel@vger.kernel.org, Ingo Molnar , "H. Peter Anvin" , Hedi Berriche , x86@kernel.org Subject: Re: [PATCH 1/2] Disable UV BAU by default In-Reply-To: <1458579852-37580-2-git-send-email-athorlton@sgi.com> Message-ID: References: <1458579852-37580-1-git-send-email-athorlton@sgi.com> <1458579852-37580-2-git-send-email-athorlton@sgi.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1051 Lines: 48 On Mon, 21 Mar 2016, Alex Thorlton wrote: First of all, please use proper patch prefixes. x86/platform/uv: .... And please fold the documentation change into the patch which changes the parameter. > static int timeout_us; > -static int nobau; > +static int nobau = 1; > static int nobau_perm; > static cycles_t congested_cycles; > > @@ -106,13 +106,22 @@ static char *stat_description[] = { > "enable: number times use of the BAU was re-enabled" > }; > > -static int __init > -setup_nobau(char *arg) > +static int __init setup_bau(char *arg) > { > - nobau = 1; > + if (!arg) > + return -EINVAL; > + > + if (!strncmp(arg, "on", 2)) { > + nobau = 0; > + pr_info("UV BAU Enabled\n"); > + } else if (!strncmp(arg, "off", 3)) { > + nobau = 1; > + pr_info("UV BAU Disabled\n"); > + } > + > return 0; > } > -early_param("nobau", setup_nobau); > +early_param("bau", setup_bau); What's the value of having that extra argument? The default is off, so we can do with a simple "bau" or "enable_bau" and be done with it. Thanks, tglx