Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932106AbcCWLge (ORCPT <rfc822;w@1wt.eu>);
	Wed, 23 Mar 2016 07:36:34 -0400
Received: from foss.arm.com ([217.140.101.70]:45815 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754931AbcCWLg1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 23 Mar 2016 07:36:27 -0400
Subject: Re: [PATCH 2/2 v5] irqchip/Layerscape: Add SCFG MSI controller
 support
To: Alexander Stein <alexander.stein@systec-electronic.com>
References: <1457321782-3245-1-git-send-email-Minghuan.Lian@nxp.com>
 <7239962.9Fyo0vfqsc@ws-stein> <56F27914.3080908@arm.com>
 <1547622.IrIylJTC5Q@ws-stein>
Cc: linux-kernel@vger.kernel.org, Minghuan Lian <Minghuan.Lian@nxp.com>,
        linux-arm-kernel@lists.infradead.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>, Roy Zang <roy.zang@nxp.com>,
        Mingkai Hu <mingkai.hu@nxp.com>, Stuart Yoder <stuart.yoder@nxp.com>,
        Yang-Leo Li <leoyang.li@nxp.com>
From: Marc Zyngier <marc.zyngier@arm.com>
X-Enigmail-Draft-Status: N1110
Organization: ARM Ltd
Message-ID: <56F27FB7.4010804@arm.com>
Date: Wed, 23 Mar 2016 11:36:23 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.5.0
MIME-Version: 1.0
In-Reply-To: <1547622.IrIylJTC5Q@ws-stein>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1000
Lines: 23

On 23/03/16 11:19, Alexander Stein wrote:
> On Wednesday 23 March 2016 11:08:04, Marc Zyngier wrote:
>>> Using an intel e1000e card which uses 3 MSIs. But the IRQ numbers are a bit strange though:
>>>> grep eth3 /proc/interrupts
>>>>
>>>>  63:         49          0       MSI 134742016 Edge      eth3-rx-0
>>>>  64:          3          0       MSI 134742017 Edge      eth3-tx-0
>>>>  65:          4          0       MSI 134742018 Edge      eth3
>>
>> This is a virtual interrupt number (despite being displayed as a hwirq),
>> computed from the PCI requester ID and the MSI index. You shouldn't
>> infer anything from it.
> 
> Why show it anyway then if you can't infer anything?

Because this field conveys meaningful information for almost every other
interrupt in the system. I'm not going to special case the MSI layer
just on the ground that it may not be always useful (and in fact it *is*
useful if you know what the generating function is).

	M.
-- 
Jazz is not dead. It just smells funny...