Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754784AbcCWLxZ (ORCPT ); Wed, 23 Mar 2016 07:53:25 -0400 Received: from mail-lb0-f170.google.com ([209.85.217.170]:35255 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752508AbcCWLxR (ORCPT ); Wed, 23 Mar 2016 07:53:17 -0400 Subject: Re: [PATCH] net: ping: make ping_v6_sendmsg static To: Haishuang Yan , "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy References: <1458727191-36958-1-git-send-email-yanhaishuang@cmss.chinamobile.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: <56F283A6.6020801@cogentembedded.com> Date: Wed, 23 Mar 2016 14:53:10 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1458727191-36958-1-git-send-email-yanhaishuang@cmss.chinamobile.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 423 Lines: 16 On 3/23/2016 12:59 PM, Haishuang Yan wrote: > As ping_v6_sendmsg is used only in this file, > making it static > > The body of "pingv6_prot" and "pingv6_protosw" were > moved at the middle of the file, to avoid having to > declare some static prototypes. > > Signed-off-by: Haishuang Yan These seem as 2 independent changes, so should be in 2 separate patches. [...] MBR, Sergei