Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754764AbcCWMFx (ORCPT ); Wed, 23 Mar 2016 08:05:53 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:58204 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752917AbcCWMFo (ORCPT ); Wed, 23 Mar 2016 08:05:44 -0400 Date: Wed, 23 Mar 2016 12:05:35 +0000 From: Mark Brown To: Alexander Stein Cc: linux-kernel@vger.kernel.org Message-ID: <20160323120535.GK2566@sirena.org.uk> References: <1981840.HVGTg07J9M@ws-stein> <4116114.XWfjkrStv7@ws-stein> <20160323113939.GI2566@sirena.org.uk> <2546687.zGbvS8bYIW@ws-stein> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mtMub/tMKeDWEZ+I" Content-Disposition: inline In-Reply-To: <2546687.zGbvS8bYIW@ws-stein> X-Cookie: Walk softly and carry a megawatt laser. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: regmap: mmio: regression in pre-v4.6-rc1 X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1764 Lines: 46 --mtMub/tMKeDWEZ+I Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 23, 2016 at 12:50:53PM +0100, Alexander Stein wrote: As I said previously please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > > > In regmap_mmio_gen_context ctx->reg_read is set to regmap_mmio_read32= le and=20 > > > ctx->reg_write to regmap_mmio_write32le respectively. > > So how does that happen then? We set these values if the bus is > > default, little or native endian but if it's big endian we go into a > > completely different case... > Well, in regmap_mmio_gen_context config->reg_format_endian is still > set to REGMAP_ENDIAN_DEFAULT. of_syscon_register sets > config.val_format_endian (notice val_ instead of reg_) depending on > "big-endian" (or "little-endian") property. I'm kinda confused > regarding reg_format_endian and val_format_endian. Dunno what should > be set in which way. Ah, I see. That's definitely broken - if we're changing the value format we should be checking the value. --mtMub/tMKeDWEZ+I Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW8oaOAAoJECTWi3JdVIfQXiAH/2mr9/5hMRwoxsL6fpx0p/mf dQzqxTOLHCG/x41le1X0pIrGsmmXuTqfQi88+z9z7Q/MCdSccrueNQH37Nm8TK3a rmqR/XaqaDlVoIrSVyrbmih2vTQEdvGy5FgQyqCeC6Nl5tE85Ggm9fXJeY5zC/mB bI9biARPBaYGICe93wjYI5S3PGUQ1tj5SdNpyP3SESYu6Fx4yquCo4/JUcMiTGz/ 18LEuaQA+edAseXc4Kh4nb4MAoXF5yfmfVHdYE3HnARVVs4RFdE89iCM5psFm9hg tf5az5kkccBeeYzq6YlW7wEI+oFFHB5uIppB5RpjuWmzqwbRcvjqYeKLndgxb7k= =i9Fd -----END PGP SIGNATURE----- --mtMub/tMKeDWEZ+I--