Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755101AbcCWMWe (ORCPT <rfc822;w@1wt.eu>);
	Wed, 23 Mar 2016 08:22:34 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:6645 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753448AbcCWMWb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 23 Mar 2016 08:22:31 -0400
Subject: Re: [PATCH v4 2/3] IB/hns: Add HiSilicon RoCE driver support
To: Christoph Hellwig <hch@infradead.org>
References: <1458655621-3618-1-git-send-email-oulijun@huawei.com>
 <1458655621-3618-3-git-send-email-oulijun@huawei.com>
 <20160322185412.GA6262@infradead.org>
CC: <dledford@redhat.com>, <sean.hefty@intel.com>, <hal.rosenstock@gmail.com>,
        <davem@davemloft.net>, <jeffrey.t.kirsher@intel.com>,
        <jiri@mellanox.com>, <ogerlitz@mellanox.com>,
        <linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <netdev@vger.kernel.org>, <gongyangming@huawei.com>,
        <xiaokun@huawei.com>, <tangchaofei@huawei.com>,
        <haifeng.wei@huawei.com>, <yisen.zhuang@huawei.com>,
        <yankejian@huawei.com>, <lisheng011@huawei.com>,
        <charles.chenxin@huawei.com>, <linuxarm@huawei.com>
From: oulijun <oulijun@huawei.com>
Message-ID: <56F28A24.5010107@huawei.com>
Date: Wed, 23 Mar 2016 20:20:52 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20160322185412.GA6262@infradead.org>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.61.25.147]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020202.56F28A31.01B0,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: b83658ae66c1e452ffecef80bcbcd89b
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 969
Lines: 23

On 2016/3/23 2:54, Christoph Hellwig wrote:
>>  drivers/infiniband/Kconfig                         |    1 +
>>  drivers/infiniband/hw/Makefile                     |    1 +
>>  drivers/infiniband/hw/hisilicon/hns/Kconfig        |   10 +
> 
> To fit in with the other drivers drop the hisilicon level
> of the directory hierarchy.
> 
> Haven't had time to look at the actual driver yet so far, though.
> 
> .
> 
Hi Christoph Hellwig,
   surely, I considered that other drivers will be put into the hisilicon
level of the directory hierarchy. These drivers will support RDMA function which
will be developed for a series of hisilicon chip. Because of the consideration, I drop the
level.
   In additon that, i thought that the patch of RoCE driver which supported the base function of RDMA is huge. However,
It is not splitted into patches in form of patchset. I don't put a better strategy that it neither make mistakes
of building and running nor huge.

thanks
Lijun Ou