Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755349AbcCWNaT (ORCPT ); Wed, 23 Mar 2016 09:30:19 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33140 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753074AbcCWNaO (ORCPT ); Wed, 23 Mar 2016 09:30:14 -0400 Date: Wed, 23 Mar 2016 14:30:11 +0100 From: Michal Hocko To: Vaishali Thakkar Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, n-horiguchi@ah.jp.nec.com, mike.kravetz@oracle.com, hillf.zj@alibaba-inc.com, baiyaowei@cmss.chinamobile.com, dingel@linux.vnet.ibm.com, kirill.shutemov@linux.intel.com, dave.hansen@linux.intel.com, paul.gortmaker@windriver.com, catalin.marinas@arm.com, will.deacon@arm.com, cmetcalf@ezchip.com, linux-arm-kernel@lists.infradead.org, james.hogan@imgtec.com, linux-metag@vger.kernel.org, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org Subject: Re: [PATCH v2 0/6] mm/hugetlb: Fix commandline parsing behavior for invalid hugepagesize Message-ID: <20160323133011.GG7059@dhcp22.suse.cz> References: <1458734844-14833-1-git-send-email-vaishali.thakkar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458734844-14833-1-git-send-email-vaishali.thakkar@oracle.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1086 Lines: 25 On Wed 23-03-16 17:37:18, Vaishali Thakkar wrote: > Current code fails to ignore the 'hugepages=' parameters when unsupported > hugepagesize is specified. With this patchset, introduce new architecture > independent routine hugetlb_bad_size to handle such command line options. > And then call it in architecture specific code. > > Changes since v1: > - Separated different architecture specific changes in different > patches > - CC'ed all arch maintainers The hugetlb parameters parsing is a bit mess but this at least makes it behave more consistently. Feel free to add to all patches Acked-by: Michal Hocko On a side note. I have received patches with broken threading - the follow up patches are not in the single thread under this cover email. I thought this was the default behavior of git send-email but maybe your (older) version doesn't do that. --thread option would enforce that (with --no-chain-reply-to) or you can set it up in the git config. IMHO it is always better to have the patchset in the single email thread. -- Michal Hocko SUSE Labs