Message-ID: <1458748164.6393.649.camel@hpe.com>
Subject: Re: [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface
From: Toshi Kani <toshi.kani@hpe.com>
To: Borislav Petkov <bp@suse.de>
Cc: mingo@kernel.org, hpa@zytor.com, tglx@linutronix.de, mcgrof@suse.com,
        jgross@suse.com, paul.gortmaker@windriver.com, konrad.wilk@oracle.com,
        elliott@hpe.com, x86@kernel.org, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org
Date: Wed, 23 Mar 2016 09:49:24 -0600
In-Reply-To: <20160323085141.GC8031@pd.tnic>
References: <1458175619-32206-1-git-send-email-toshi.kani@hpe.com>
	 <20160322165944.GC5656@pd.tnic> <1458682845.6393.614.camel@hpe.com>
	 <20160323085141.GC8031@pd.tnic>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 927
Lines: 28

On Wed, 2016-03-23 at 09:51 +0100, Borislav Petkov wrote:
> On Tue, Mar 22, 2016 at 03:40:45PM -0600, Toshi Kani wrote:
> > Will change to "Prevent the OS from initializing the PAT MSR".
> > 
> > I wanted to clarify that "disable" does not mean to disable PAT MSR.
> 
> How do you "disable PAT MSR" ?

We can't, but I thought not everyone knows how it works...

> I think you're overdocumenting this. pat_disable() is as clear as day
> what it does. It doesn't need any commenting...

Right, maybe I am just paranoid.  I will remove the comment as you
suggested.

> > I've run checkpatch.pl and thought it was OK to have this warning
> > (instead of a >80 warning) since the error message part was not split.
> >  The "attempting" part is for debugging and its string is passed from
> > the caller. 
> 
> We always put the quoted strings on a single line for easier grepping.
> Forget the 80-cols rule.

OK.

Thanks,
-Toshi