Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755644AbcCWPJS (ORCPT ); Wed, 23 Mar 2016 11:09:18 -0400 Received: from mail.kernel.org ([198.145.29.136]:53864 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754652AbcCWPJP (ORCPT ); Wed, 23 Mar 2016 11:09:15 -0400 Date: Wed, 23 Mar 2016 10:09:10 -0500 From: Rob Herring To: Pramod Gurav Cc: andy.gross@linaro.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dan.j.williams@intel.com, vinod.koul@intel.com, okaya@codeaurora.org, architt@codeaurora.org Subject: Re: [PATCH 2/2] dmaengine: qcom_bam_dma: Bypass BAM init if not managed locally Message-ID: <20160323150910.GA16272@rob-hp-laptop> References: <1458640151-15150-1-git-send-email-gpramod@codeaurora.org> <1458640151-15150-3-git-send-email-gpramod@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458640151-15150-3-git-send-email-gpramod@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1708 Lines: 44 On Tue, Mar 22, 2016 at 03:19:11PM +0530, Pramod Gurav wrote: > On some QOCM platforms BAM control registers are managed remotely s/QOCM/QCOM/ > hence can not be accessed by application processor for writes. Pass > a DT property qcom,bam_ctrl_remote to declare the same to skip bam_init. Is this a property of specific SOCs or a configuration option? If the former, use the SOC specific compatible string to determine this option. > Move the pipe number initialisation from bam_init to probe functiom > as it should be done for all platforms. > > Signed-off-by: Pramod Gurav > --- > Documentation/devicetree/bindings/dma/qcom_bam_dma.txt | 3 +++ > drivers/dma/qcom/bam_dma.c | 18 +++++++++++------- > 2 files changed, 14 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/qcom_bam_dma.txt b/Documentation/devicetree/bindings/dma/qcom_bam_dma.txt > index 1c9d48e..46e33ae 100644 > --- a/Documentation/devicetree/bindings/dma/qcom_bam_dma.txt > +++ b/Documentation/devicetree/bindings/dma/qcom_bam_dma.txt > @@ -13,6 +13,8 @@ Required properties: > - clock-names: must contain "bam_clk" entry > - qcom,ee : indicates the active Execution Environment identifier (0-7) used in > the secure world. > +- qcom,bam_ctrl_remote: Use when BAM global device control is managed remotely Don't use '_' in property names. > + and not locally by the application processor. > > Example: > > @@ -24,6 +26,7 @@ Example: > clock-names = "bam_clk"; > #dma-cells = <1>; > qcom,ee = <0>; > + qcom,bam_ctrl_remote; > }; > > DMA clients must use the format described in the dma.txt file, using a two cell