Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755987AbcCWQDm (ORCPT ); Wed, 23 Mar 2016 12:03:42 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:43577 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755319AbcCWQDk (ORCPT ); Wed, 23 Mar 2016 12:03:40 -0400 Subject: Re: [PATCH v2 0/6] mm/hugetlb: Fix commandline parsing behavior for invalid hugepagesize To: Michal Hocko References: <1458734844-14833-1-git-send-email-vaishali.thakkar@oracle.com> <20160323133011.GG7059@dhcp22.suse.cz> Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, n-horiguchi@ah.jp.nec.com, mike.kravetz@oracle.com, hillf.zj@alibaba-inc.com, baiyaowei@cmss.chinamobile.com, dingel@linux.vnet.ibm.com, kirill.shutemov@linux.intel.com, dave.hansen@linux.intel.com, paul.gortmaker@windriver.com, catalin.marinas@arm.com, will.deacon@arm.com, cmetcalf@ezchip.com, linux-arm-kernel@lists.infradead.org, james.hogan@imgtec.com, linux-metag@vger.kernel.org, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org From: Vaishali Thakkar Message-ID: <56F2BDE3.40309@oracle.com> Date: Wed, 23 Mar 2016 21:31:39 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160323133011.GG7059@dhcp22.suse.cz> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1304 Lines: 31 On Wednesday 23 March 2016 07:00 PM, Michal Hocko wrote: > On Wed 23-03-16 17:37:18, Vaishali Thakkar wrote: >> Current code fails to ignore the 'hugepages=' parameters when unsupported >> hugepagesize is specified. With this patchset, introduce new architecture >> independent routine hugetlb_bad_size to handle such command line options. >> And then call it in architecture specific code. >> >> Changes since v1: >> - Separated different architecture specific changes in different >> patches >> - CC'ed all arch maintainers > The hugetlb parameters parsing is a bit mess but this at least makes it > behave more consistently. Feel free to add to all patches > Acked-by: Michal Hocko > > On a side note. I have received patches with broken threading - the > follow up patches are not in the single thread under this cover email. > I thought this was the default behavior of git send-email but maybe your > (older) version doesn't do that. --thread option would enforce that > (with --no-chain-reply-to) or you can set it up in the git config. IMHO > it is always better to have the patchset in the single email thread. > Yes, now I have set up my git config for that. Hopefully, things will work properly - patchset in a single thread from the next time. Thanks. -- Vaishali