Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756325AbcCWQm4 (ORCPT ); Wed, 23 Mar 2016 12:42:56 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:33107 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756287AbcCWQmx (ORCPT ); Wed, 23 Mar 2016 12:42:53 -0400 Date: Wed, 23 Mar 2016 10:42:39 -0600 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: Peter Huewe , Marcel Selhorst , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH] tpm_atmel: drop tpm_atmel specific fields from tpm_vendor_specific Message-ID: <20160323164239.GA16336@obsidianresearch.com> References: <1458709822-6677-1-git-send-email-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458709822-6677-1-git-send-email-jarkko.sakkinen@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 412 Lines: 12 On Wed, Mar 23, 2016 at 07:10:22AM +0200, Jarkko Sakkinen wrote: > Introduced a private struct tpm_atmel_priv that contains the variables > have_region and region_size that were previously located in struct > tpm_vendor_specific. These fields were only used by tpm_atmel. This seems fine to me Reviewd-by: Jason Gunthorpe Although I think we should delete this driver Jason