Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932656AbcCWS0A (ORCPT ); Wed, 23 Mar 2016 14:26:00 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:60149 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932529AbcCWSZ6 (ORCPT ); Wed, 23 Mar 2016 14:25:58 -0400 Date: Wed, 23 Mar 2016 14:25:56 -0400 (EDT) Message-Id: <20160323.142556.2023977823696366302.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: yanhaishuang@cmss.chinamobile.com, kaber@trash.net, nicolas.dichtel@6wind.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vlan: propagate gso_min_segs From: David Miller In-Reply-To: <1458700432.10868.32.camel@edumazet-glaptop3.roam.corp.google.com> References: <1458696914-16088-1-git-send-email-yanhaishuang@cmss.chinamobile.com> <1458700432.10868.32.camel@edumazet-glaptop3.roam.corp.google.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 23 Mar 2016 11:25:57 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 572 Lines: 17 From: Eric Dumazet Date: Tue, 22 Mar 2016 19:33:52 -0700 > On Wed, 2016-03-23 at 09:35 +0800, Haishuang Yan wrote: >> vlan drivers lack proper propagation of gso_min_segs from lower device. >> >> Signed-off-by: Haishuang Yan >> --- > > The plan was to get rid of gso_min_segs, as nothing uses it. > > Otherwise I would have included this in my recent patches... > > For such a rare 'issue' , we believe ndo_features_check() is better, > because it does not slow down the fast path. I'm not aplpying this.