Message-ID: <1458758064.10868.42.camel@edumazet-glaptop3.roam.corp.google.com>
Subject: Re: [PATCH] vlan: propagate gso_min_segs
From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: yanhaishuang@cmss.chinamobile.com, kaber@trash.net,
        nicolas.dichtel@6wind.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Wed, 23 Mar 2016 11:34:24 -0700
In-Reply-To: <20160323.142556.2023977823696366302.davem@davemloft.net>
References: <1458696914-16088-1-git-send-email-yanhaishuang@cmss.chinamobile.com>
	 <1458700432.10868.32.camel@edumazet-glaptop3.roam.corp.google.com>
	 <20160323.142556.2023977823696366302.davem@davemloft.net>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 737
Lines: 23

On Wed, 2016-03-23 at 14:25 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Tue, 22 Mar 2016 19:33:52 -0700
> 
> > On Wed, 2016-03-23 at 09:35 +0800, Haishuang Yan wrote:
> >> vlan drivers lack proper propagation of gso_min_segs from lower device.
> >> 
> >> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
> >> ---
> > 
> > The plan was to get rid of gso_min_segs, as nothing uses it.
> > 
> > Otherwise I would have included this in my recent patches...
> > 
> > For such a rare 'issue' , we believe ndo_features_check() is better,
> > because it does not slow down the fast path.
> 
> I'm not aplpying this.

I am adding to my TODO list a revert, when net-next opens again.

Thanks.